EXCEPTION at.bitfire.dav4jvm.exception.InvalidPropertyException: XML text for DAV:Push:topic must not be empty

[mbiebl]

Since a couple of days I notice the following errors:

07-22 23:07:07.062 13840 13863 I davx5   : [push.PushRegistrationWorker] Running push registration worker
07-22 23:07:07.063 13840 13863 I davx5   : [push.PushRegistrationWorker] No UnifiedPush endpoint configured
07-22 23:07:07.065 13840 13869 I WM-WorkerWrapper: Worker result SUCCESS for Work [ id=f4acb46e-405b-4e10-960c-a51c7d1d1faf, tags={ at.bitfire.davdroid.push.PushRegistrationWorker } ]
07-22 23:07:08.536 13840 13866 W dav4jvm : [at.bitfire.dav4jvm.Property] Ignoring invalid property
07-22 23:07:08.536 13840 13866 W dav4jvm : EXCEPTION at.bitfire.dav4jvm.exception.InvalidPropertyException: XML text for DAV:Push:topic must not be empty
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.XmlUtils.requireReadText(XmlUtils.kt:50)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.property.push.Topic$Factory.create(Topic.kt:2)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.property.push.Topic$Factory.create(Topic.kt:1)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.PropertyRegistry.create(PropertyRegistry.kt:22)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.Property$Companion.parse(Property.kt:69)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.PropStat$Companion.parse(PropStat.kt:78)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.Response$Companion.parse(Response.kt:478)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.DavResource.processMultiStatus$parseMultiStatus(DavResource.kt:51)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.DavResource.processMultiStatus(DavResource.kt:16)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.DavResource.processMultiStatus(DavResource.kt:9)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.dav4jvm.DavResource.propfind(DavResource.kt:76)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.davdroid.servicedetection.CollectionListRefresher.refreshHomesetsAndTheirCollections$davx5_404010101_4_4_1_1_gplayRelease(CollectionListRefresher.kt:217)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.davdroid.servicedetection.RefreshCollectionsWorker.doWork$lambda$3(RefreshCollectionsWorker.kt:107)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.davdroid.servicedetection.RefreshCollectionsWorker.$r8$lambda$ofjjgk229eCP_3BIUZuO_f4S4Vs(RefreshCollectionsWorker.kt:1)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.davdroid.servicedetection.RefreshCollectionsWorker$$ExternalSyntheticLambda0.invoke(R8$$SyntheticClass:3)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.InterruptibleKt$runInterruptible$2.invokeSuspend(Interruptible.kt:75)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.InterruptibleKt$runInterruptible$2.invoke(Interruptible.kt:13)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:5)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:41)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.InterruptibleKt.runInterruptible$default(Interruptible.kt:9)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at at.bitfire.davdroid.servicedetection.RefreshCollectionsWorker.doWork(RefreshCollectionsWorker.kt:143)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at androidx.work.CoroutineWorker$startWork$1.invokeSuspend(CoroutineWorker.kt:31)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:111)
07-22 23:07:08.536 13840 13866 W dav4jvm : 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:98)

I suppose this is related to the latest addition of webdav-push support in davx5.

The server is running nextcloud 29.0.4

[mbiebl]

This started happening after upgrading from 4.4.1 to 4.4.1.1.

[mbiebl]

If this an expected error condition then the exception should be caught and and handled appropriately I think

[rfc2822]

It is. The log message is informative for debugging and contains the Throwable for more information.

[mbiebl]

Feels weird to have exceptions during normal operation as this clutters the log significantly.

[rfc2822]

I agree, fixed with #53.