Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the dashboard, state change of any variable triggers a re-render of the other components #2032

Open
gorkem-bwl opened this issue Apr 4, 2025 · 9 comments

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Apr 4, 2025

When I create a filter, the state change of any variable triggers rerendering of several unrelated components, which makes a visible shaking of the whole dashboard.

Ideally, user expects only the table rows (excluding the header itself) to change accordingly. All other widgets in the page should be stationary.

Screen.Recording.2025-04-03.at.7.30.18.PM.mov
@Rimaru06
Copy link

Rimaru06 commented Apr 6, 2025

hey @gorkem-bwl i would like to work on this ?

@gorkem-bwl
Copy link
Contributor Author

@Rimaru06 sure, go ahead please, and thank you for your interest in Checkmate :)

@gorkem-bwl
Copy link
Contributor Author

@Rimaru06 can you tell us about the progress? :)

@Rimaru06
Copy link

Rimaru06 commented Apr 9, 2025

@gorkem-bwl Thanks for checking in! I’ve analyzed the issue where filter changes cause unnecessary re-renders across the dashboard, especially affecting components that shouldn’t be affected like charts and headers. I haven’t started implementing the solution yet, but I’ve identified a few possible approaches like moving the filter state closer to the component and using React.memo to isolate updates. I’ll be starting work on this shortly and will prioritize minimizing UI jitter. I’ll keep you updated as I make progress

@gorkem-bwl
Copy link
Contributor Author

Many thanks @Rimaru06 and appreciate the detailed response & heads up here.

@Br0wnHammer
Copy link
Member

@Rimaru06, there is one more issue on the same page. When you try to change the theme of the app. It re-renders all the components. This only occurs on uptime page. Others work as planned. Can you verify if this issue occurs on your end as well and let us know.

@Rimaru06
Copy link

@Rimaru06, there is one more issue on the same page. When you try to change the theme of the app. It re-renders all the components. This only occurs on uptime page. Others work as planned. Can you verify if this issue occurs on your end as well and let us know.

yes it does

@Br0wnHammer
Copy link
Member

@Rimaru06, there is one more issue on the same page. When you try to change the theme of the app. It re-renders all the components. This only occurs on uptime page. Others work as planned. Can you verify if this issue occurs on your end as well and let us know.

yes it does

I'm confident that the root cause is the same for both issues. Please proceed with creating a single pull request to address them. If you need any assistance, we're all available on Discord. Don't hesitate to reach out.

@Rimaru06
Copy link

@Rimaru06, there is one more issue on the same page. When you try to change the theme of the app. It re-renders all the components. This only occurs on uptime page. Others work as planned. Can you verify if this issue occurs on your end as well and let us know.

yes it does

I'm confident that the root cause is the same for both issues. Please proceed with creating a single pull request to address them. If you need any assistance, we're all available on Discord. Don't hesitate to reach out.

for sure , thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants