feat(schematic-src): Remove path mappings

(#25)

* feat(schematic-src): Remove path mappings

Relative paths are favorable - these schematics should be usable in projects
without having to set custom TS paths up.

* feat(schematics): Remove template path mappings

* fix template arg

* get sandbox-app tests passing

* adjust test scripts

Author: reidsvilleneuve

.gitignore

@@ -1,7 +1,7 @@
 # See http://help.github.com/ignore-files/ for more about ignoring files.
 
 # compiled output
-/dist
+**/dist
 /tmp
 /out-tsc
 

package.json

@@ -10,11 +10,11 @@
     "build:schematic": "tsc -p tsconfig.schematic.json",
     "build:schematic:watch": "tsc -p tsconfig.schematic.json -watch",
     "clean": "git checkout HEAD -- sandbox-app && git clean -fd sandbox-app",
-    "clean:launch": "npm run clean && npm run launch",
+    "clean:launch": "yarn clean && yarn launch",
     "clean:launch:all": "yarn build:run:fileBuilder && yarn build:schematic && yarn clean:launch",
     "launch": "cd sandbox-app && ng g @briebug/ngrx-entity-schematic:ngrx-entity-schematic",
-    "test:ci": "npm run clean:launch && npm run test:sandbox && npm run clean",
-    "test:sandbox": "cd sandbox-app && npm run lint && npm run test && npm run e2e && npm run build",
+    "test:ci": "yarn clean:launch briebug --init && yarn test:sandbox && yarn clean",
+    "test:sandbox": "cd sandbox-app && yarn lint && yarn test && yarn e2e && yarn build",
     "link:schematic": "yarn link && cd sandbox-app && yarn link @briebug/ngrx-entity-schematic"
   },
   "dependencies": {

sandbox-app/e2e/src/app.e2e-spec.ts

@@ -9,6 +9,6 @@ describe('workspace-project App', () => {
 
   it('should display welcome message', () => {
     page.navigateTo();
-    expect(page.getParagraphText()).toEqual('Welcome to app!');
+    expect(page.getParagraphText()).toEqual('Test Entities');
   });
 });

sandbox-app/package.json

@@ -5,7 +5,7 @@
     "ng": "ng",
     "start": "ng serve",
     "build": "ng build",
-    "test": "ng test",
+    "test": "ng test --watch=false",
     "lint": "ng lint",
     "e2e": "ng e2e"
   },

sandbox-app/src/app/entities/containers/entity/entity.component.html

@@ -8,7 +8,7 @@ <h1>Test Entity</h1>
   [disableFields]="isLoading$ | async"
   [showErrors]="showFormErrors"
   (briebugChanged)="onBriebugChanged($event)"
-  (submit)="onSubmit($event)"
+  (submit)="onSubmit()"
 ></app-briebug-form>
 
 <a routerLink="/entities">Back to list</a>

schematic-src/src/app/core/core.module.ts

@@ -2,7 +2,7 @@ import { ModuleWithProviders, NgModule, Optional, SkipSelf } from '@angular/core
 import { CommonModule } from '@angular/common';
 import { HttpClientModule } from '@angular/common/http';
 
-import { BriebugService } from '@state/briebug/briebug.service';
+import { BriebugService } from '../state/briebug/briebug.service';
 
 @NgModule({
   imports: [CommonModule, HttpClientModule],

schematic-src/src/app/core/in-memory-data.service.ts

@@ -1,4 +1,4 @@
-import { Briebug } from '@state/briebug/briebug.model';
+import { Briebug } from '../state/briebug/briebug.model';
 
 export class InMemoryDataService {
   createDb() {

schematic-src/src/app/entities/components/entity-form/entity-form.component.spec.ts

@@ -2,10 +2,11 @@ import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { SimpleChange } from '@angular/core';
 import { ReactiveFormsModule } from '@angular/forms';
 
-import { BriebugFormComponent } from './entity-form.component';
-import { generateBriebug } from '@state/briebug/briebug.model';
 import { fromEvent } from 'rxjs';
 
+import { BriebugFormComponent } from './entity-form.component';
+import { generateBriebug } from '../../../state/briebug/briebug.model';
+
 describe('BreibugFormComponent', () => {
   let component: BriebugFormComponent;
   let fixture: ComponentFixture<BriebugFormComponent>;

schematic-src/src/app/entities/components/entity-form/entity-form.component.ts

@@ -8,12 +8,13 @@ import {
   OnDestroy,
   ChangeDetectionStrategy
 } from '@angular/core';
-
-import { Briebug } from '@state/briebug/briebug.model';
 import { FormGroup, Validators, FormBuilder } from '@angular/forms';
 import { Subject } from 'rxjs';
+
 import { takeUntil, skip, debounceTime } from 'rxjs/operators';
 
+import { Briebug } from '../../../state/briebug/briebug.model';
+
 @Component({
   selector: 'app-briebug-form',
   templateUrl: './entity-form.component.html',

schematic-src/src/app/entities/containers/entity-list/entity-list.component.spec.ts

@@ -4,14 +4,14 @@ import { RouterTestingModule } from '@angular/router/testing';
 import { Store, StoreModule } from '@ngrx/store';
 
 import { BriebugListComponent } from './entity-list.component';
-import { appReducer } from '@state/app.reducer';
-import { AppState } from '@state/app.interfaces';
+import { appReducer } from '../../../state/app.reducer';
+import { AppState } from '../../../state/app.interfaces';
 import {
   SearchAllBriebugEntities,
   SearchAllBriebugEntitiesSuccess,
   SearchAllBriebugEntitiesFail
-} from '@state/briebug/briebug.actions';
-import { generateBriebugArray } from '@state/briebug/briebug.model';
+} from '../../../state/briebug/briebug.actions';
+import { generateBriebugArray } from '../../../state/briebug/briebug.model';
 
 describe('BriebugListComponent', () => {
   let component: BriebugListComponent;

schematic-src/src/app/entities/containers/entity-list/entity-list.component.ts

@@ -8,13 +8,13 @@ import {
   getAllBriebugEntitiesAsArray,
   getLoading,
   getError
-} from '@state/briebug';
-import { BriebugState } from '@state/briebug/briebug.reducer';
+} from '../../../state/briebug';
+import { BriebugState } from '../../../state/briebug/briebug.reducer';
 import {
   SearchAllBriebugEntities,
   DeleteBriebugById
-} from '@state/briebug/briebug.actions';
-import { Briebug } from '@state/briebug/briebug.model';
+} from '../../../state/briebug/briebug.actions';
+import { Briebug } from '../../../state/briebug/briebug.model';
 
 @Component({
   templateUrl: './entity-list.component.html',

schematic-src/src/app/entities/containers/entity/entity.component.html

@@ -8,7 +8,7 @@ <h1>Test Entity</h1>
   [disableFields]="isLoading$ | async"
   [showErrors]="showFormErrors"
   (briebugChanged)="onBriebugChanged($event)"
-  (submit)="onSubmit($event)"
+  (submit)="onSubmit()"
 ></app-briebug-form>
 
 <a routerLink="/entities">Back to list</a>

schematic-src/src/app/entities/containers/entity/entity.component.spec.ts

@@ -3,22 +3,22 @@ import { RouterTestingModule } from '@angular/router/testing';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { ActivatedRoute, convertToParamMap } from '@angular/router';
 
-import * as fromRoot from '@state/app.reducer';
+import * as fromRoot from '../../../state/app.reducer';
 import { Store, StoreModule } from '@ngrx/store';
 import { Subject } from 'rxjs';
 
 import { BriebugComponent } from './entity.component';
 import { BriebugFormComponent } from '../../components/entity-form/entity-form.component';
-import { AppState } from '@state/app.interfaces';
-import { generateBriebug } from '@state/briebug/briebug.model';
+import { AppState } from '../../../state/app.interfaces';
+import { generateBriebug } from '../../../state/briebug/briebug.model';
 import {
   LoadBriebugById,
   LoadBriebugByIdSuccess,
   SelectBriebugById,
   LoadBriebugByIdFail,
   UpdateBriebug,
   InsertBriebug
-} from '@state/briebug/briebug.actions';
+} from '../../../state/briebug/briebug.actions';
 import { skip } from 'rxjs/operators';
 
 describe('BriebugComponent', () => {

schematic-src/src/app/entities/containers/entity/entity.component.ts

@@ -12,15 +12,15 @@ import {
   combineLatest
 } from 'rxjs/operators';
 
-import { getLoading, getSelectedBriebug, getError } from '@state/briebug';
-import { Briebug } from '@state/briebug/briebug.model';
+import { getLoading, getSelectedBriebug, getError } from '../../../state/briebug';
+import { Briebug } from '../../../state/briebug/briebug.model';
 import {
   LoadBriebugById,
   InsertBriebug,
   UpdateBriebug,
   SelectBriebugById
-} from '@state/briebug/briebug.actions';
-import { BriebugState } from '@state/briebug/briebug.reducer';
+} from '../../../state/briebug/briebug.actions';
+import { BriebugState } from '../../../state/briebug/briebug.reducer';
 
 @Component({
   templateUrl: './entity.component.html',

schematic-src/src/app/state/briebug/briebug.actions.ts

@@ -1,7 +1,7 @@
 import { Action } from '@ngrx/store';
 import { Update } from '@ngrx/entity';
 import { Briebug } from './briebug.model';
-import { BriebugSearchQuery } from '@state/briebug/briebug.reducer';
+import { BriebugSearchQuery } from './briebug.reducer';
 
 export enum BriebugActionTypes {
   InsertBriebug = '[Briebug] Insert',

schematic-src/src/app/state/briebug/briebug.effects.spec.ts

@@ -23,7 +23,7 @@ import {
 import { generateBriebug, generateBriebugArray } from './briebug.model';
 // TODO: Change this path when you move your service file:
 import { BriebugService } from './briebug.service';
-import { BriebugEffects } from '@state/briebug/briebug.effects';
+import { BriebugEffects } from './briebug.effects';
 
 describe('BriebugEffects', () => {
   let actions: Observable<any>;

schematic-src/src/app/state/briebug/briebug.service.ts

@@ -9,7 +9,7 @@ import { HttpClient } from '@angular/common/http';
 
 import { Observable, of } from 'rxjs';
 import { switchMap } from 'rxjs/operators';
-import { Briebug } from '@state/briebug/briebug.model';
+import { Briebug } from './briebug.model';
 
 @Injectable({
   providedIn: 'root'

schematic-src/src/app/state/state.module.ts

@@ -9,7 +9,7 @@ import { StoreModule } from '@ngrx/store';
 import { appMetaReducers, appReducer } from './app.reducer';
 import { CustomRouterStateSerializer } from './state-utils';
 import { environment } from '../../environments/environment';
-import { BriebugEffects } from '@state/briebug/briebug.effects';
+import { BriebugEffects } from './briebug/briebug.effects';
 
 @NgModule({
   imports: [

schematic-src/tsconfig.json

@@ -2,10 +2,6 @@
   "compileOnSave": false,
   "compilerOptions": {
     "baseUrl": "./",
-    "paths": {
-      "@state/*": ["src/app/state/*"],
-      "@core/*": ["src/app/core/*"]
-    },
     "outDir": "./dist/out-tsc",
     "sourceMap": true,
     "declaration": false,

src/ngrx-entity/__files__/__name@dasherize@if-flat__/__name@dasherize__.actions.ts

@@ -1,7 +1,7 @@
 import { Action } from '@ngrx/store';
 import { Update } from '@ngrx/entity';
 import { <%= classify(name) %> } from './<%= name %>.model';
-import { <%= classify(name) %>SearchQuery } from '@state/<%= name %>/<%= name %>.reducer';
+import { <%= classify(name) %>SearchQuery } from './<%= name %>.reducer';
 
 export enum <%= classify(name) %>ActionTypes {
   Insert<%= classify(name) %> = '[<%= classify(name) %>] Insert',

src/ngrx-entity/__files__/__name@dasherize@if-flat__/__name@dasherize__.effects.spec.ts

@@ -23,7 +23,7 @@ import {
 import { generate<%= classify(name) %>, generate<%= classify(name) %>Array } from './<%= name %>.model';
 // TODO: Change this path when you move your service file:
 import { <%= classify(name) %>Service } from './<%= name %>.service';
-import { <%= classify(name) %>Effects } from '@state/<%= name %>/<%= name %>.effects';
+import { <%= classify(name) %>Effects } from './<%= name %>.effects';
 
 describe('<%= classify(name) %>Effects', () => {
   let actions: Observable<any>;

src/ngrx-entity/__files__/__name@dasherize@if-flat__/__name@dasherize__.service.ts

@@ -9,7 +9,7 @@ import { HttpClient } from '@angular/common/http';
 
 import { Observable, of } from 'rxjs';
 import { switchMap } from 'rxjs/operators';
-import { <%= classify(name) %> } from '@state/<%= name %>/<%= name %>.model';
+import { <%= classify(name) %> } from './<%= name %>.model';
 
 @Injectable({
   providedIn: 'root'

src/ngrx-entity/__files__/state.module.ts

@@ -9,7 +9,7 @@ import { StoreModule } from '@ngrx/store';
 import { appMetaReducers, appReducer } from './app.reducer';
 import { CustomRouterStateSerializer } from './state-utils';
 import { environment } from '../../environments/environment';
-import { <%= classify(name) %>Effects } from '@state/<%= name %>/<%= name %>.effects';
+import { <%= classify(name) %>Effects } from './<%= name %>/<%= name %>.effects';
 
 @NgModule({
   imports: [