fixes jdorn#734 remove unnecessary conole.log() calls; enable eslint rule for no-console

Author: robocoder

.eslintrc

@@ -1,4 +1,7 @@
 {
   "extends":["standard"],
-  "env": {"browser": true}
-}
+  "env": {"browser": true},
+  "rules": {
+    "no-console": "error"
+  }
+}

src/defaults.js

@@ -303,6 +303,7 @@ Object.entries(editors).forEach(([i, editor]) => { editors[i].options = editor.o
 
 /* Default upload handler */
 function upload (type, file, cbs) {
+  // eslint-disable-next-line no-console
   console.log('Upload handler required for upload editor')
 }
 

src/editors/autocomplete.js

@@ -30,6 +30,7 @@ export class AutocompleteEditor extends StringEditor {
       /* single property options from schema "options.autocomplete" */
       options = this.expandCallbacks('autocomplete', extend({}, {
         search: (jseditor, input) => {
+          // eslint-disable-next-line no-console
           console.log(`No "search" callback defined for autocomplete in property "${jseditor.key}"`)
           return []
         },

src/editors/upload.js

@@ -189,6 +189,7 @@ export class UploadEditor extends AbstractEditor {
         this.preview.appendChild(img)
       }
       img.onerror = error => {
+        // eslint-disable-next-line no-console
         console.error('upload error', error, error.currentTarget)
       }
       img.src = this.container.querySelector('a').href

src/schemaloader.js

@@ -98,6 +98,7 @@ export class SchemaLoader {
       : ''
     const ref = this._getRef(fetchUrl, refObj)
     if (!this.refs[ref]) { /* if reference not found */
+      // eslint-disable-next-line no-console
       console.warn(`reference:'${ref}' not found!`)
     } else if (recurseAllOf && hasOwnProperty(this.refs[ref], 'allOf')) {
       const allOf = this.refs[ref].allOf
@@ -224,7 +225,8 @@ export class SchemaLoader {
           try {
             response = JSON.parse(r.responseText)
           } catch (e) {
-            window.console.log(e)
+            // eslint-disable-next-line no-console
+            console.log(e)
             throw new Error(`Failed to parse external ref ${fetchUrl}`)
           }
           if (!(typeof response === 'boolean' || typeof response === 'object') || response === null || Array.isArray(response)) {
@@ -243,7 +245,8 @@ export class SchemaLoader {
           }, fetchUrl, fileBase)
         } else {
           /* Request failed */
-          window.console.log(r)
+          // eslint-disable-next-line no-console
+          console.log(r)
           throw new Error(`Failed to fetch ref via ajax- ${url}`)
         }
       }

src/themes/bootstrap4.js

@@ -246,6 +246,7 @@ export class bootstrap4Theme extends AbstractTheme {
       if (window.jQuery && window.jQuery().tooltip) {
         window.jQuery(button).tooltip()
       } else {
+        // eslint-disable-next-line no-console
         console.warn('Could not find popper jQuery plugin of Bootstrap.')
       }
     } else if (this.options.tooltip === 'css') {

src/themes/spectre.js

@@ -146,7 +146,6 @@ export class spectreTheme extends AbstractTheme {
   }
 
   getMultiCheckboxHolder (controls, label, description, infoText) {
-    console.log('mul')
     return super.getMultiCheckboxHolder(controls, label, description, infoText)
   }
 

src/validator.js

@@ -244,7 +244,6 @@ export class Validator {
             /* If this item has a specific schema tied to it */
             /* Validate against it */
             if (schema.items[i]) {
-              console.log('-->')
               errors.push(...this._validateSchema(schema.items[i], value[i], `${path}.${i}`))
               /* If all additional items are allowed */
             } else if (schema.additionalItems === true) {
@@ -385,8 +384,6 @@ export class Validator {
           k = keys[i]
           /* Check property names that don't match */
           if (typeof schema.propertyNames === 'boolean') {
-            console.log(schema.propertyNames ? 'TRUE' : 'FALSE')
-            console.log('*' + k + '*')
             if (schema.propertyNames === true) {
               continue
             }