Skip to content

Commit 0d16fd1

Browse files
authored
Merge pull request #16 from bvanjoi/next
release: 0.0.11
2 parents 3d720d9 + 672f8ed commit 0d16fd1

File tree

4 files changed

+11
-32
lines changed

4 files changed

+11
-32
lines changed

__test__/index.spec.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ import factory, { RawResolverOptions } from '../index'
77
test('sync function from native code', (t) => {
88
const resolver = factory.create({})
99
const result = factory.resolve(resolver, __dirname, './fixture/lib')
10-
t.is(result.path, path.resolve(__dirname, './fixture/lib.js'))
11-
t.is(result.status, true)
10+
t.is(result, path.resolve(__dirname, './fixture/lib.js'))
1211
})
1312

1413
test('resolve do not exist file', (t) => {
@@ -33,12 +32,10 @@ test('extensions options', (t) => {
3332
}
3433
const resolver = factory.create(resolverOptions)
3534
const result = factory.resolve(resolver, __dirname, './fixture/lib')
36-
t.is(result.path, path.resolve(__dirname, './fixture/lib.ts'))
37-
t.is(result.status, true)
35+
t.is(result, path.resolve(__dirname, './fixture/lib.ts'))
3836
// with query and fragment
3937
const result2 = factory.resolve(resolver, __dirname, './fixture/lib?query#fragment')
40-
t.is(result2.path, path.resolve(__dirname, './fixture/lib.ts?query#fragment'))
41-
t.is(result2.status, true)
38+
t.is(result2, path.resolve(__dirname, './fixture/lib.ts?query#fragment'))
4239
})
4340

4441

@@ -57,10 +54,8 @@ test('alias options', (t) => {
5754
}
5855
const resolver = factory.create(resolverOptions)
5956
const result = factory.resolve(resolver, __dirname, '@alias/lib')
60-
t.is(result.path, path.resolve(__dirname, './fixture/lib.js'))
61-
t.is(result.status, true)
57+
t.is(result, path.resolve(__dirname, './fixture/lib.js'))
6258

6359
const result2 = factory.resolve(resolver, __dirname, '@false/lib')
64-
t.is(result2.path, undefined)
65-
t.is(result2.status, false)
60+
t.is(result2, "false")
6661
})

index.d.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,4 @@ export interface ResolverInternal {
3232

3333
}
3434
export function create(options: RawResolverOptions): ExternalObject<ResolverInternal>
35-
export interface ResolveResult {
36-
status: boolean
37-
path?: string
38-
}
39-
export function resolve(resolver: ExternalObject<ResolverInternal>, base_dir: string, id: string): {status: boolean, path?: string}
35+
export function resolve(resolver: ExternalObject<ResolverInternal>, base_dir: string, id: string): string | false

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nodejs-resolver",
3-
"version": "0.0.10",
3+
"version": "0.0.11",
44
"description": "node binding for nodejs-resolver",
55
"main": "index.js",
66
"license": "MIT",

src/lib.rs

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -84,33 +84,21 @@ pub fn create(options: RawResolverOptions) -> Result<External<Resolver>, napi::E
8484
Ok(External::new(resolver))
8585
}
8686

87-
#[napi(object)]
88-
pub struct ResolveResult {
89-
pub status: bool,
90-
pub path: Option<String>,
91-
}
92-
9387
#[napi(
9488
ts_args_type = "resolver: ExternalObject<ResolverInternal>, base_dir: string, id: string",
95-
ts_return_type = "{status: boolean, path?: string}"
89+
ts_return_type = "string | false"
9690
)]
9791
pub fn resolve(
9892
resolver: External<Resolver>,
9993
base_dir: String,
10094
id: String,
101-
) -> Result<ResolveResult, napi::Error> {
95+
) -> Result<String, napi::Error> {
10296
match (*resolver).resolve(Path::new(&base_dir), &id) {
10397
Ok(val) => {
10498
if let nodejs_resolver::ResolverResult::Info(info) = val {
105-
Ok(ResolveResult {
106-
status: true,
107-
path: Some(format!("{}{}{}", info.path.display(), &info.request.query, &info.request.fragment)),
108-
})
99+
Ok(format!("{}{}{}", info.path.display(), &info.request.query, &info.request.fragment))
109100
} else {
110-
Ok(ResolveResult {
111-
status: false,
112-
path: None,
113-
})
101+
Ok(String::from("false"))
114102
}
115103
}
116104
Err(err) => Err(napi::Error::new(napi::Status::GenericFailure, err)),

0 commit comments

Comments
 (0)