✅enable to run unit tests in .NET 472

Author: fforjanAVEVA

src/Extensions.cs

@@ -20,6 +20,7 @@ public static unsafe string GetString(this Encoding encoding, Span<byte> bytes)
         {
             fixed (byte* bytesPtr = bytes)
             {
+                if(bytesPtr == null) return string.Empty;
                 return encoding.GetString(bytesPtr, bytes.Length);
             }
         }
@@ -29,6 +30,7 @@ public static unsafe string GetString(this Encoding encoding, ReadOnlySpan<byte>
         {
             fixed (byte* bytesPtr = bytes)
             {
+                if(bytesPtr == null) return string.Empty;
                 return encoding.GetString(bytesPtr, bytes.Length);
             }
         }
@@ -39,6 +41,7 @@ public static unsafe int GetBytes(this Encoding encoding, Span<char> chars, Span
             fixed (char* charsPtr = chars)
             fixed (byte* bytesPtr = bytes)
             {
+                if(bytesPtr == null) return 0;
                 return encoding.GetBytes(charsPtr, chars.Length, bytesPtr, bytes.Length);
             }
         }
@@ -49,6 +52,7 @@ public static unsafe int GetBytes(this Encoding encoding, ReadOnlySpan<char> cha
             fixed (char* charsPtr = chars)
             fixed (byte* bytesPtr = bytes)
             {
+                if(bytesPtr == null) return 0;
                 return encoding.GetBytes(charsPtr, chars.Length, bytesPtr, bytes.Length);
             }
         }
@@ -59,6 +63,7 @@ public static unsafe int GetBytes(this Encoding encoding, string chars, Span<byt
             fixed (char* charsPtr = chars)
             fixed (byte* bytesPtr = bytes)
             {
+                if(bytesPtr == null) return 0;
                 return encoding.GetBytes(charsPtr, chars.Length, bytesPtr, bytes.Length);
             }
         }

tests/StoreDataTests.cs

@@ -1,8 +1,6 @@
 using System;
-using System.Diagnostics.Metrics;
 using System.Linq;
 using FluentAssertions;
-using Newtonsoft.Json.Linq;
 using Xunit;
 
 namespace Wasmtime.Tests

tests/WasiTests.cs

@@ -7,6 +7,54 @@
 
 namespace Wasmtime.Tests
 {
+#if NETFRAMEWORK // the following code is a polyfill as it already exists in .Net
+    using System.Runtime.CompilerServices;
+    using System.Collections;
+
+    sealed class ReferenceEqualityComparer : IEqualityComparer<object?>, IEqualityComparer
+    {
+        private ReferenceEqualityComparer() { }
+
+        /// <summary>
+        /// Gets the singleton <see cref="ReferenceEqualityComparer"/> instance.
+        /// </summary>
+        public static ReferenceEqualityComparer Instance { get; } = new ReferenceEqualityComparer();
+
+        /// <summary>
+        /// Determines whether two object references refer to the same object instance.
+        /// </summary>
+        /// <param name="x">The first object to compare.</param>
+        /// <param name="y">The second object to compare.</param>
+        /// <returns>
+        /// <see langword="true"/> if both <paramref name="x"/> and <paramref name="y"/> refer to the same object instance
+        /// or if both are <see langword="null"/>; otherwise, <see langword="false"/>.
+        /// </returns>
+        /// <remarks>
+        /// This API is a wrapper around <see cref="object.ReferenceEquals(object?, object?)"/>.
+        /// It is not necessarily equivalent to calling <see cref="object.Equals(object?, object?)"/>.
+        /// </remarks>
+        public new bool Equals(object? x, object? y) => ReferenceEquals(x, y);
+
+        /// <summary>
+        /// Returns a hash code for the specified object. The returned hash code is based on the object
+        /// identity, not on the contents of the object.
+        /// </summary>
+        /// <param name="obj">The object for which to retrieve the hash code.</param>
+        /// <returns>A hash code for the identity of <paramref name="obj"/>.</returns>
+        /// <remarks>
+        /// This API is a wrapper around <see cref="RuntimeHelpers.GetHashCode(object)"/>.
+        /// It is not necessarily equivalent to calling <see cref="object.GetHashCode()"/>.
+        /// </remarks>
+        public int GetHashCode(object? obj)
+        {
+            // Depending on target framework, RuntimeHelpers.GetHashCode might not be annotated
+            // with the proper nullability attribute. We'll suppress any warning that might
+            // result.
+            return RuntimeHelpers.GetHashCode(obj!);
+        }
+    }
+#endif    
+
     public class WasiTests
     {
         [Theory]
@@ -70,7 +118,7 @@ public void ItHasSpecifiedEnvironment(string path)
 
             for (int i = 0; i < env.Count; ++i)
             {
-                var kvp = memory.ReadNullTerminatedString(memory.ReadInt32(i * 4)).Split("=");
+                var kvp = memory.ReadNullTerminatedString(memory.ReadInt32(i * 4)).Split('=');
                 Assert.Equal(env[kvp[0]], kvp[1]);
             }
         }

tests/Wasmtime.Tests.csproj

@@ -1,7 +1,14 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup Condition="$([MSBuild]::IsOSPlatform('Windows'))">    
+    <TargetFrameworks>net8.0;net472</TargetFrameworks>  
+  </PropertyGroup>
+  <PropertyGroup Condition="!($([MSBuild]::IsOSPlatform('Windows')))">    
+    <TargetFrameworks>net8.0</TargetFrameworks>  
+  </PropertyGroup>
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <LangVersion>Latest</LangVersion>
     <IsPackable>false</IsPackable>
   </PropertyGroup>