feat: support replacing a task on a single transaction

Author: marian2js

contracts/ChainJetRunner.sol

@@ -33,7 +33,7 @@ contract ChainJetRunner is OwnableUpgradeable {
         __Ownable_init();
     }
 
-    function enableTask(address _task) external payable {
+    function enableTask(address _task) public payable {
         require(IOwnable(_task).owner() == msg.sender, 'enableTask: caller is not the owner');
         require(tasks[_task].addr == address(0), 'enableTask: task already enabled');
         if (msg.value > 0) {
@@ -45,13 +45,18 @@ contract ChainJetRunner is OwnableUpgradeable {
         emit TaskEnabled(_task, msg.sender);
     }
 
-    function disableTask(address _task) external {
+    function disableTask(address _task) public {
         require(tasks[_task].addr != address(0), 'disableTask: task not enabled');
         require(tasks[_task].owner == msg.sender, 'disableTask: caller is not the owner');
         delete tasks[_task];
         emit TaskDisabled(_task);
     }
 
+    function replaceTask(address _oldTask, address _newTask) external {
+        disableTask(_oldTask);
+        enableTask(_newTask);
+    }
+
     function deposit() external payable {
         balances[msg.sender] += msg.value;
         emit Deposit(msg.sender, msg.value);

test-contracts/ChainJetRunner.spec.ts

@@ -132,6 +132,45 @@ describe('ChainJetRunner', () => {
     })
   })
 
+  describe('replaceTask', () => {
+    it('should replace a task', async () => {
+      const chainJetRunner = await deployChainJetRunner()
+      const taskMock = await deployTaskMock(alice)
+      const taskMock2 = await deployTaskMock(alice)
+      await chainJetRunner.connect(alice).enableTask(taskMock.address, { value: parseUnits('1') })
+      await chainJetRunner.connect(alice).replaceTask(taskMock.address, taskMock2.address)
+
+      const taskEnabled = await chainJetRunner.tasks(taskMock.address)
+      expect(taskEnabled[0]).to.eq(ZERO_ADDRESS)
+      expect(taskEnabled[1]).to.eq(ZERO_ADDRESS)
+
+      const taskEnabled2 = await chainJetRunner.tasks(taskMock2.address)
+      expect(taskEnabled2[0]).to.eq(taskMock2.address)
+      expect(taskEnabled2[1]).to.eq(alice.address)
+    })
+
+    it('should revert if caller is not the owner', async () => {
+      const chainJetRunner = await deployChainJetRunner()
+      const taskMock = await deployTaskMock(alice)
+      const taskMock2 = await deployTaskMock(alice)
+      await chainJetRunner.connect(alice).enableTask(taskMock.address, { value: parseUnits('1') })
+
+      await expect(chainJetRunner.connect(eve).replaceTask(taskMock.address, taskMock2.address)).to.be.revertedWith(
+        'disableTask: caller is not the owner',
+      )
+    })
+
+    it('should revert if the task is not enabled', async () => {
+      const chainJetRunner = await deployChainJetRunner()
+      const taskMock = await deployTaskMock(carol)
+      const taskMock2 = await deployTaskMock(carol)
+
+      await expect(chainJetRunner.connect(carol).replaceTask(taskMock.address, taskMock2.address)).to.be.revertedWith(
+        'disableTask: task not enabled',
+      )
+    })
+  })
+
   describe('deposit', () => {
     it('should increase depositor balance', async () => {
       const chainJetRunner = await deployChainJetRunner()