-
Notifications
You must be signed in to change notification settings - Fork 33
confusing behavior att init --contract #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
from top of my head we have two options once you run 1 - if the contract you provide with the flag |
I would say option 2 is more user friendly as long as we always inform the end user about that swap! |
|
@jiparis did we end up implementing this? I remember we talked about it In any case I've tried it like this as part of the quickstart and didn't work
|
It was implemented here #1902. What's the error? |
not an error, but instead that I can't see it updating the contract. |
@jiparis it would be nice if you could give it a check to see if we can close this |
Sure, att init never updates the contract, that's the confusing part. I'll take a look |
oh, so we didn't add it in the end I guess? |
Please check #1974, this should fix it. |
when you run for example
chainloop att init --workflow my-wf --contract my-contract ...
what happens is1 - a new workflow called
my-wf
is created (if it doesn't exist) associated with the contractmy-contract
2 - a new run is performed
This means that if you after the first run, you provide another contract name
chainloop att init --workflow my-wf --contract contract-2
, the first contract (my-contract
will be used, in other words, the providedcontract-2
will be ignored, which was reported as unexpected behaviorThe text was updated successfully, but these errors were encountered: