update type specs to pass dialyzer check

Author: chaoslawful

Diff for: .gitignore

@@ -0,0 +1,3 @@
+logs
+*.beam
+

Diff for: Makefile

@@ -0,0 +1,22 @@
+all: dialyze
+
+build:
+	@./rebar compile
+
+ct: clean build
+	@./rebar ct
+
+dialyze: build
+	@./rebar dialyze
+
+doc:
+	@./rebar doc
+
+clean:
+	@./rebar clean
+	@find . -name '*.beam' -exec rm -f '{}' ';'
+	@rm -f doc/*.html doc/*.png doc/*.css doc/edoc-info
+	@rm -rf logs/
+
+.PHONY: all build ct dialyze doc clean
+

Diff for: src/zfor_app.erl

@@ -10,13 +10,13 @@
 % @spec start(
 %			StartType::('normal' | {'takeover', Node::node()} | {'failover', Node::node()}),
 %			StartArgs::term()
-%		) -> {'ok', pid()} | {'ok', pid(), term()} | {'error', term()}
+%		) -> {'ok', pid()} | {'error', term()}
 % @end
 % {{{
 -spec start(
 	StartType::('normal' | {'takeover', Node::node()} | {'failover', Node::node()}),
 	StartArgs::term()
-) -> {'ok', pid()} | {'ok', pid(), term()} | {'error', term()}.
+) -> {'ok', pid()} | {'error', term()}.
 
 start(_Type, _Args) ->
 	% 从应用配置参数环境中读取conf_path参数

Diff for: src/zfor_httpclient.erl

@@ -102,7 +102,7 @@ request(Req) ->
 % @doc Receive and parse HTTP responses.
 % @end
 % {{{
--spec recv_http_resp(Sock::pid(), Buf::binary()) ->
+-spec recv_http_resp(Sock::port(), Buf::binary()) ->
 	{ok,
 		{
 			{Version::string(), Status::integer(), Reason::string()},
@@ -138,6 +138,15 @@ recv_http_resp(Sock, Buf) ->
 % @doc Receive and parse response headers and body
 % @end
 % {{{
+-spec recv_http_header(Sock::port(), Res::tuple(), Buf::binary()) ->
+	{ok,
+		{
+			{Version::string(), Status::integer(), Reason::string()},
+			[{Field::string(), Value::string()}],
+			Body::string()
+		}
+	} | {error, Reason::term()}.
+
 recv_http_header(Sock, {ok, {{Ver, Code, Reason}, Headers, Body}} = Res, Buf) ->
 	case erlang:decode_packet(httph, Buf, []) of
 		{error, DReason} -> {error, DReason};
@@ -180,6 +189,8 @@ recv_http_header(Sock, {ok, {{Ver, Code, Reason}, Headers, Body}} = Res, Buf) ->
 % @doc Receive response body.
 % @end
 % {{{
+-spec recv_http_body(Sock::port(), Len::integer(), LB::list(binary())) -> binary().
+
 recv_http_body(_, N, LB) when N =< 0 ->
 	iolist_to_binary(lists:reverse(LB));
 

Diff for: src/zfor_main.erl

@@ -183,7 +183,7 @@ system_continue(Parent, DbgOpts, State) ->
 	),
 	loop(Parent, NewDbgOpts, State).
 
--spec system_terminate(Reason :: term(), Parent :: pid(), DbgOpts :: [term()], State :: server_state()) -> true.
+-spec system_terminate(Reason :: term(), Parent :: pid(), DbgOpts :: [term()], State :: server_state()) -> none().
 system_terminate(Reason, _Parent, DbgOpts, State) ->
 	sys:handle_debug(DbgOpts, {?MODULE, debug_output}, ?MODULE, {"service terminating", State}),
 	stop_all_proc(State),

Diff for: src/zfor_sup.erl

@@ -9,7 +9,7 @@
 start_link(ConfPath) ->
 	supervisor:start_link({'local', ?ZFOR_SUPERVISOR_SRVNAME}, ?MODULE, ConfPath).
 
--spec init(ConfPath::string()) -> {'ok', {{atom(), integer(), integer()}, [child_spec()]}} | 'ignore'.
+-spec init(ConfPath::string()) -> {'ok', {{atom(), integer(), integer()}, [child_spec()]}}.
 init(ConfPath) ->
 	{ok,{
 			% 重启策略为one_for_one，即哪个服务死掉就重启对应的服务