Skip to content

Commit bb1eb0b

Browse files
committed
fix: Don't emit MsgsNoticed when a message was seen on IMAP
`receive_imf` doesn't emit `MsgsNoticed` on receipt of an IMAP-seen message, so the code was inconsistent. The easiest fix is to not emit `MsgsNoticed` when a message was seen on another device, we don't want to emit `MsgsNoticed` if not all messages are seen, otherwise that removes useful notifications from UIs and may lead to missing messages. Checking that all previous chat messages are at least `InNoticed` looks complicated, let's not do this for now.
1 parent fff4020 commit bb1eb0b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/imap.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1284,7 +1284,6 @@ impl Session {
12841284
context.on_archived_chats_maybe_noticed();
12851285
}
12861286
for updated_chat_id in updated_chat_ids {
1287-
context.emit_event(EventType::MsgsNoticed(updated_chat_id));
12881287
chatlist_events::emit_chatlist_item_changed(context, updated_chat_id);
12891288
}
12901289

0 commit comments

Comments
 (0)