Skip to content

Add JSON-RPC API to list past members #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
link2xt opened this issue Jan 16, 2025 · 3 comments · Fixed by #6442
Closed

Add JSON-RPC API to list past members #6440

link2xt opened this issue Jan 16, 2025 · 3 comments · Fixed by #6442
Assignees
Labels
enhancement New feature or request

Comments

@link2xt
Copy link
Collaborator

link2xt commented Jan 16, 2025

Past members are now sent around even though we are going to expire them after 60 days with #6430.
To make users aware of this we need to display them somewhere, naturally at the end of the member list after all the current members.

There is a Rust get_past_chat_contacts API, but we also need a JSON-RPC API to display this list at least on Desktop.

@link2xt link2xt added the enhancement New feature or request label Jan 16, 2025
@link2xt link2xt self-assigned this Jan 16, 2025
@hpk42
Copy link
Contributor

hpk42 commented Jan 20, 2025 via email

@r10s
Copy link
Contributor

r10s commented Jan 20, 2025

showing that in the UI might also frighten ppl unnecessarily and create an incentive to have an option to get removed even from there -- where in reality, it is not an secret that one was in a group at all, providing these information some more days, does not add much -- a new member could also just ask another member if XY was in the group, having in mind, we do not see group members as enemies. for ppl watching network traffic or owning the server, the information are anyway not visible as usually e2ee

@link2xt
Copy link
Collaborator Author

link2xt commented Jan 20, 2025

This information is sent in the network and past members are even added to the contact list of new members joining the group, so it is better if users are aware why this happens.

If delta does not expose past members in UI, then someone who seizes the phone can not
directly find out who was part of a group but needs to deploy some extra software
and extraction.

I think it is better if users know this information is there and can be extracted. If they need security in such scenarios, they need to create a new group or maybe even new burner profiles.

I can think of some scenarios when my non-public account was added to groups that are meant as somewhat public groups. I then added my other profile and left the group. Since past members are sent, now in such case I need to clone group and say "use this to onboard people, the original group has wrong profile of mine" instead of adding public profile and leaving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants