Skip to content

Members added by legacy DC set timestamps of all recipients to the timestamp of receiving a message #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
link2xt opened this issue Jan 17, 2025 · 0 comments · Fixed by #6475
Assignees
Labels
bug Something is not working

Comments

@link2xt
Copy link
Collaborator

link2xt commented Jan 17, 2025

When a member using new DC that has new group consistency algorithm #6404 and stores member timestamps gets added to groups by old DC client (or outdated invite bot), they set the timestamps for all members to the date when the message was received. This may result in re-adding members that have left the group before this new DC client received a "Member added" message.

Same may happen if DC client using the latest version with group consistency algorithm gets added to a group by non-DC MUA, but in that case it does not matter as MUA is allowed to add members anyway.

We should set all timestamps to 0 instead because actual timestamps are not known.

@link2xt link2xt added the bug Something is not working label Jan 17, 2025
@link2xt link2xt changed the title Members added by legacy DC accept all members with theTo: Members added by legacy DC set timestamps of all recipients to the timestamp of receiving a message Jan 17, 2025
@link2xt link2xt self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant