-
Notifications
You must be signed in to change notification settings - Fork 17
Display network information of checkpoints created with Podman #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
can i work on this? |
@nick2432 Thank you for reaching out! You are more than welcome to work on this feature. |
@rst0git Hello, can I work on this issue? |
@deveshgoyal1000 thank you for the interest! Please feel free to take this up :) |
Okay Thanks! |
Hey @rst0git @snprajwal 👋 Apologies for the delay on this! I’ve been spending the past few weeks diving deep into the codebase and trying to wrap my head around everything. It took a bit longer than expected. But I’ve finally got it working and will be opening a PR shortly! |
Currently, checkpointctl shows IP address information for checkpoints created with CRI-O but not with Podman. For Podman checkpoints, this information is stored in network.status in JSON format. This commit adds support for extracting and displaying network information from Podman container checkpoints by: - Adding network.status file parsing functionality - Displaying IP and MAC address information in checkpoint show output - Adding test coverage for network information parsing - Maintaining compatibility with existing checkpoint formats - Updated import references from lib to metadata for consistency Testing Results: 1. Test Environment: - Container: nginx (docker.io/library/nginx:latest) - Container ID: 4cf1a79a043a - Runtime: crun 2. Verification: - Successfully extracts network.status from checkpoint - Correctly displays IP address (10.88.0.2/16) - Correctly displays MAC address (c2:10:ff:79:ea:72) - Maintains all existing checkpoint information Fixes: checkpoint-restore#132 Signed-off-by: deveshgoyal1000 <[email protected]>
Currently, checkpointctl shows IP address information for checkpoints created with CRI-O but not with Podman. This patch adds support for extracting and displaying network information from Podman container checkpoints. The network information is stored in network.status file in JSON format: { podman: { interfaces: { eth0: { subnets: [{ ipnet: 10.88.0.9/16, gateway: 10.88.0.1 }], mac_address: f2:99:8d:fb:5a:57 } } } } Implementation details: - Extract network.status file from checkpoint archive - Parse JSON content to get IP and MAC address information - Add network information columns to output table - Display IP address and MAC address for Podman containers - Add test coverage for network information parsing - Handle network information extraction errors gracefully This enables users to see network configuration for Podman checkpoints, providing parity with CRI-O checkpoint display. Fixes: checkpoint-restore#132 Signed-off-by: deveshgoyal1000 <[email protected]>
Currently, checkpointctl shows IP address information for checkpoints created with CRI-O but not with Podman. This patch adds support for extracting and displaying network information from Podman container checkpoints. The network information is stored in network.status file in JSON format: { podman: { interfaces: { eth0: { subnets: [{ ipnet: 10.88.0.9/16, gateway: 10.88.0.1 }], mac_address: f2:99:8d:fb:5a:57 } } } } Implementation details: - Extract network.status file from checkpoint archive - Parse JSON content to get IP and MAC address information - Add network information columns to output table - Display IP address and MAC address for Podman containers - Add test coverage for network information parsing - Handle network information extraction errors gracefully Files changed: - internal/container.go: Add network info display - internal/podman_network.go: Network info extraction - internal/podman_network_test.go: Test coverage Testing: - All Go unit tests pass - All 61 BATS integration tests pass - Container checkpoint tests pass - Network information display verified in EC2 This enables users to see network configuration for Podman checkpoints, providing parity with CRI-O checkpoint display. Fixes: checkpoint-restore#132 Signed-off-by: deveshgoyal1000 <[email protected]>
checkpointctl
currently shows IP address information for checkpoints created with CRI-O but not with Podman. For checkpoints created with Podman, this information is stored innetwork.status
, which has content in a JSON format like the following example:To enable this feature, we need to extract the network.status file from the checkpoint and parse its content.
The text was updated successfully, but these errors were encountered: