Skip to content

Commit bc44641

Browse files
committed
Code review snippets to address from @davidben
Also: * sus_if_msvc for attributes should be sus_if_msvc_not_cl * "language is msvc variant" vs "compiler is msvc" * sus_if_gnuc_language * test wrapping for each integer size, esp < 32bit * not destroy nevervalue? since it's in a union can that be a requirement on NeverValueTypes, and is C++ okay with constructing an object in a place where one already exists and was not destroyed?
1 parent 7147b8f commit bc44641

File tree

3 files changed

+48
-90
lines changed

3 files changed

+48
-90
lines changed

sus/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ target_sources(subspace PUBLIC
131131
"iter/zip.h"
132132
"macros/__private/compiler_bugs.h"
133133
"macros/assume.h"
134-
"macros/arch.h"
135134
"macros/builtin.h"
136135
"macros/compiler.h"
137136
"macros/eval_macro.h"

sus/macros/arch.h

-23
This file was deleted.

0 commit comments

Comments
 (0)