Handle yet more tidy messages

Author: ckormanyos

ref_app/src/mcal/host/mcal_wdg_watchdog.h

@@ -119,7 +119,7 @@
       };
 
       template<const typename watchdog_base::base_timer_type::tick_type MyPeriod>
-      watchdog<MyPeriod> watchdog<MyPeriod>::my_watchdog(thread_function);
+      watchdog<MyPeriod> watchdog<MyPeriod>::my_watchdog(thread_function); // NOLINT(cert-err58-cpp)
 
       template<const typename watchdog_base::base_timer_type::tick_type MyPeriod>
       std::atomic_flag watchdog<MyPeriod>::my_lock = ATOMIC_FLAG_INIT;

ref_app/src/mcal_led/mcal_led_boolean_state_base.h

@@ -14,11 +14,12 @@
 
   class led_boolean_state_base : public mcal::led::led_base // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions)
   {
+  public:
+    ~led_boolean_state_base() override = default;
+
   protected:
     constexpr led_boolean_state_base() = default;
 
-    ~led_boolean_state_base() override = default;
-
     auto toggle() -> void override
     {
       // Toggle the LED state.

ref_app/src/mcal_led/mcal_led_console.h

@@ -15,12 +15,14 @@
 
   namespace mcal { namespace led {
 
-  class led_console final : public mcal::led::led_boolean_state_base
+  class led_console final : public mcal::led::led_boolean_state_base // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions)
   {
   public:
     explicit constexpr led_console(const std::uint_fast8_t i)
       : my_index(i) { }
 
+    ~led_console() override = default;
+
     auto toggle() -> void override
     {
       using base_class_type = mcal::led::led_boolean_state_base;

ref_app/src/mcal_led/mcal_led_port.h

@@ -23,6 +23,8 @@
       port_type::set_direction_output();
     }
 
+    ~led_port() override = default;
+
     auto toggle() -> void override
     {
       using base_class_type = led_boolean_state_base;

ref_app/src/mcal_led/mcal_led_port_inverted.h

@@ -23,6 +23,8 @@
       port_type::set_direction_output();
     }
 
+    ~led_port_inverted() override = default;
+
     auto toggle() -> void override
     {
       using base_class_type = led_boolean_state_base;

ref_app/src/mcal_led/mcal_led_pwm.h

@@ -21,6 +21,8 @@
       my_pwm.set_duty(static_cast<std::uint16_t>(UINT8_C(0)));
     }
 
+    ~led_pwm() override = default;
+
     auto state_is_on() const -> bool override { return (my_pwm.get_duty() > static_cast<std::uint16_t>(UINT8_C(0))); }
 
     auto toggle() -> void override

ref_app/src/mcal_led/mcal_led_rgb_base.h

@@ -17,6 +17,8 @@
   class led_rgb_base : public mcal::led::led_boolean_state_base
   {
   public:
+    ~led_rgb_base() override = default;
+
     auto toggle() -> void override
     {
       using base_class_type = mcal::led::led_boolean_state_base;

ref_app/src/os/os_cfg.h

@@ -8,12 +8,12 @@
 #ifndef OS_CFG_2011_10_20_H
   #define OS_CFG_2011_10_20_H
 
+  #include <util/utility/util_time.h>
+
   #include <cstddef>
   #include <cstdint>
   #include <limits>
 
-  #include <util/utility/util_time.h>
-
   // Declare the task initialization and the task function of the idle process.
   namespace sys { namespace idle {
 
@@ -52,7 +52,8 @@
   {
     // Enumerate the task IDs. Note that the order in this list must
     // be identical with the order of the tasks in the task list below.
-    enum class task_id_type
+
+    enum class task_id_type // NOLINT(performance-enum-size)
     {
       task_id_app_led,
       task_id_app_benchmark,
@@ -67,10 +68,10 @@
     using tick_type  = timer_type::tick_type;
     using event_type = std::uint_fast16_t;
 
-    static_assert(std::numeric_limits<os::tick_type>::digits >= 32,
+    static_assert(std::numeric_limits<os::tick_type>::digits >= static_cast<int>(INT8_C(32)),
                   "The operating system timer_type must be at least 32-bits wide.");
 
-    static_assert(std::numeric_limits<os::event_type>::digits >= 16,
+    static_assert(std::numeric_limits<os::event_type>::digits >= static_cast<int>(INT8_C(16)),
                   "The operating system event_type must be at least 16-bits wide.");
   } // namespace os
 

ref_app/src/os/os_task_control_block.h

@@ -40,9 +40,9 @@
       auto operator=(task_control_block&&) noexcept -> task_control_block& = delete;
 
     private:
-      const function_type my_init;
-      const function_type my_func;
-      const tick_type     my_cycle;
+      const function_type my_init;  // NOLINT(cppcoreguidelines-avoid-const-or-ref-data-members)
+      const function_type my_func;  // NOLINT(cppcoreguidelines-avoid-const-or-ref-data-members)
+      const tick_type     my_cycle; // NOLINT(cppcoreguidelines-avoid-const-or-ref-data-members)
             timer_type    my_timer;
             event_type    my_event { };
 
@@ -80,6 +80,6 @@
       friend auto get_event  (event_type&) -> void;
       friend auto clear_event(const event_type&) -> void;
     };
-  }
+  } // namespace os
 
 #endif // OS_TASK_CONTROL_BLOCK_2013_07_30_H