Skip to content

ignoring-nils #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ocyzl opened this issue Nov 30, 2017 · 3 comments
Open

ignoring-nils #38

ocyzl opened this issue Nov 30, 2017 · 3 comments

Comments

@ocyzl
Copy link

ocyzl commented Nov 30, 2017

((ignoring-nils +) nil nil) returns 0, but ((ignoring-nils +) nil nil nil) returns nil. Is this difference intentional? I figure they should both return 0.
danielcompton added a commit that referenced this issue Dec 6, 2018
@danielcompton
Call 0 arity function when all arguments to ignoring-nil are nil
f7f5080 
Previously this would return nil if three or more arguments were
provided and all were nil.

Fixes #38
@danielcompton danielcompton mentioned this issue Dec 6, 2018
Open
@danielcompton
Copy link
Member

I've opened #39 to address this, but it is potentially a breaking change, so am weighing how to fix it.

@michellymenezes
Copy link

@danielcompton why would this be a breaking change?

@danielcompton
Copy link
Member

Because previously it would return nil in some cases and now it would return 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielcompton @michellymenezes @ocyzl