Skip to content

[fix] Fix CherryPy supports python3.x #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MonsterChenzhuo
Copy link

@MonsterChenzhuo MonsterChenzhuo commented Mar 19, 2025

What changes were proposed in this pull request?

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL533132612451% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1090 107 💤 0 ❌ 0 🔥 5m 52s ⏱️

Copy link
Contributor

@ranade1 ranade1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have moved to gunicorn and deprecated cherrypy server. What is the interest behind your change?

@Alterrien
Copy link

I can provide some context here (I'm not affiliated with the PR owner): Using gunicorn with sqlalchemy connectors has concurrency issues, requiring us to use only 1 gunicorn worker, making it effectively single threaded. This has considerably degraded the performance of Hue for our users (dealing with a few hundred users actively using hue), even with 6 or more hue instances running. We'll be testing this patch in the coming weeks to see how it behaves and if going back to cherryPy fixes our issues and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Results have expired, rerun the query if needed"
4 participants