drop support for CockroachDB 21.2.x

Author: timgraham

README.md

@@ -140,8 +140,3 @@ using back to Cockroach Labs. To disable this, set
 ## Known issues and limitations in CockroachDB 22.1.x and earlier
 
 - `QuerySet.select_for_update(skip_locked=True)` isn't supported.
-
-## Known issues and limitations in CockroachDB 21.2.x and earlier
-
-- Unsupported query: [UPDATE float column with integer column](https://github.com/cockroachdb/django-cockroachdb/issues/20):
-  `value type int doesn't match type FLOAT8 of column <name>`

django_cockroachdb/features.py

@@ -7,7 +7,7 @@
 
 
 class DatabaseFeatures(PostgresDatabaseFeatures):
-    minimum_database_version = (21, 2)
+    minimum_database_version = (22, 1)
 
     # Cloning databases doesn't speed up tests.
     # https://github.com/cockroachdb/django-cockroachdb/issues/206
@@ -60,8 +60,6 @@ def introspected_field_types(self):
             'SmallAutoField': 'SmallIntegerField',
         }
 
-    supports_order_by_nulls_modifier = property(operator.attrgetter('is_cockroachdb_22_1'))
-
     # CockroachDB doesn't create indexes on foreign keys.
     indexes_foreign_keys = False
 
@@ -76,10 +74,6 @@ def introspected_field_types(self):
         'swedish_ci': 'sv-x-icu',
     }
 
-    @cached_property
-    def is_cockroachdb_22_1(self):
-        return self.connection.cockroachdb_version >= (22, 1)
-
     @cached_property
     def is_cockroachdb_22_2(self):
         return self.connection.cockroachdb_version >= (22, 2)
@@ -197,19 +191,6 @@ def django_test_expected_failures(self):
             # https://github.com/cockroachdb/cockroach/issues/73587#issuecomment-988408190
             'aggregation.tests.AggregateTestCase.test_aggregation_default_using_decimal_from_database',
         })
-        if not self.connection.features.is_cockroachdb_22_1:
-            expected_failures.update({
-                # ProgrammingError: value type float doesn't match type decimal of
-                # column "n2":
-                # INSERT INTO "db_functions_decimalmodel" ("n1", "n2") VALUES ( -5.75, PI())
-                'db_functions.math.test_round.RoundTests.test_decimal_with_precision',
-                # Passing a naive datetime to cursor.execute() doesn't work in
-                # older versions of CockroachDB.
-                'timezones.tests.LegacyDatabaseTests.test_cursor_execute_accepts_naive_datetime',
-                # unknown signature: date_trunc(string, interval):
-                # https://github.com/cockroachdb/cockroach/issues/76960
-                'db_functions.datetime.test_extract_trunc.DateFunctionTests.test_extract_second_func_no_fractional',
-            })
         return expected_failures
 
     @cached_property
@@ -249,11 +230,4 @@ def django_test_skips(self):
                 'get_or_create.tests.UpdateOrCreateTransactionTests.test_updates_in_transaction',
             },
         })
-        if not self.connection.features.is_cockroachdb_22_1:
-            skips.update({
-                # https://github.com/cockroachdb/django-cockroachdb/issues/20
-                'Unsupported query: UPDATE float column with integer column.': {
-                    'expressions.tests.ExpressionsNumericTests',
-                },
-            })
         return skips

django_cockroachdb/operations.py

@@ -1,11 +1,7 @@
-import time
-
 from django.db.backends.base.base import timezone_constructor
 from django.db.backends.postgresql.operations import (
     DatabaseOperations as PostgresDatabaseOperations,
 )
-from django.db.utils import OperationalError
-from psycopg2 import errorcodes
 
 
 class DatabaseOperations(PostgresDatabaseOperations):
@@ -22,23 +18,6 @@ class DatabaseOperations(PostgresDatabaseOperations):
     }
     explain_options = frozenset(['DISTSQL', 'OPT', 'TYPES', 'VEC', 'VERBOSE'])
 
-    def datetime_extract_sql(self, lookup_type, sql, params, tzname):
-        if self.connection.features.is_cockroachdb_22_1:
-            return super().datetime_extract_sql(lookup_type, sql, params, tzname)
-        # Override the changes from https://github.com/django/django/commit/b7f263551c64e3f80544892e314ed5b0b22cc7c8
-        # which aren't compatible with older versions of CockroachDB:
-        # https://github.com/cockroachdb/cockroach/issues/76960
-        sql, params = self._convert_sql_to_tz(sql, params, tzname)
-        return self.date_extract_sql(lookup_type, sql, params)
-
-    def time_extract_sql(self, lookup_type, sql, params):
-        if self.connection.features.is_cockroachdb_22_1:
-            return super().time_extract_sql(lookup_type, sql, params)
-        # Override the changes from https://github.com/django/django/commit/b7f263551c64e3f80544892e314ed5b0b22cc7c8
-        # which aren't compatible with older versions of CockroachDB:
-        # https://github.com/cockroachdb/cockroach/issues/76960
-        return self.date_extract_sql(lookup_type, sql, params)
-
     def deferrable_sql(self):
         # Deferrable constraints aren't supported:
         # https://github.com/cockroachdb/cockroach/issues/31632
@@ -79,22 +58,6 @@ def explain_query_prefix(self, format=None, **options):
             prefix += ' (%s)' % ', '.join(extra)
         return prefix
 
-    def execute_sql_flush(self, sql_list):
-        # Retry TRUNCATE if it fails with a serialization error.
-        num_retries = 10
-        initial_retry_delay = 0.5  # The initial retry delay, in seconds.
-        backoff_ = 1.5  # For each retry, the last delay is multiplied by this.
-        next_retry_delay = initial_retry_delay
-        for retry in range(1, num_retries + 1):
-            try:
-                return super().execute_sql_flush(sql_list)
-            except OperationalError as exc:
-                if (getattr(exc.__cause__, 'pgcode', '') != errorcodes.SERIALIZATION_FAILURE or
-                        retry >= num_retries):
-                    raise
-                time.sleep(next_retry_delay)
-                next_retry_delay *= backoff_
-
     def sql_flush(self, style, tables, *, reset_sequences=False, allow_cascade=False):
         # CockroachDB doesn't support resetting sequences.
         return super().sql_flush(style, tables, reset_sequences=False, allow_cascade=allow_cascade)

teamcity-build/build-teamcity-21.2.sh

@@ -1,4 +1,4 @@
 #!/usr/bin/env bash
 set -x
 
-./teamcity-build/build-teamcity.sh "v21.2.17"
+# Not supported