Skip to content

bug: Bash file optimization #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jangirvipin opened this issue Apr 18, 2025 · 1 comment · May be fixed by #1820
Open

bug: Bash file optimization #1817

jangirvipin opened this issue Apr 18, 2025 · 1 comment · May be fixed by #1820
Labels
bug Something isn't working

Comments

@jangirvipin
Copy link

Describe the bug
As of now there is no error handling in setup.sh file . Like these command can fail and our setup will not work if we dont do error handling in setup.sh .

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to setup.sh
  2. docker command dont have error handling , so it can be failed .

Expected behavior
These commands should be properly handled .

Screenshots or GIFs
None

Info (please complete the following information):

  • chrome

Additional context
None

@jangirvipin jangirvipin added the bug Something isn't working label Apr 18, 2025
@jangirvipin
Copy link
Author

Hey you can also do something like this

if [[ $? -ne 0 ]]
for checking if previous command fails instead of current approach .
but both are fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant