Skip to content

Commit 6d13d2c

Browse files
change scorecardid to support uuid
1 parent b62c123 commit 6d13d2c

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/services/ReviewService.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ const listReviewsQuerySchema = {
9898
score: joi.score(),
9999
typeId: joi.string().uuid(),
100100
reviewerId: joi.alternatives().try(joi.id(), joi.string().uuid()),
101-
scoreCardId: joi.id(),
101+
scoreCardId: joi.alternatives().try(joi.id(), joi.string().uuid()),
102102
submissionId: joi.string().uuid(),
103103
status: joi.reviewStatus(),
104104
page: joi.id(),
@@ -206,7 +206,7 @@ createReview.schema = {
206206
.error(errors => ({
207207
message: '"reviewerId" must be a number or a string'
208208
})),
209-
scoreCardId: joi.id().required(),
209+
scoreCardId: joi.alternatives().try(joi.id().required(), joi.string().uuid().required()),
210210
submissionId: joi
211211
.string()
212212
.uuid()
@@ -338,7 +338,7 @@ updateReview.schema = {
338338
.alternatives()
339339
.try(joi.id(), joi.string().uuid())
340340
.required(),
341-
scoreCardId: joi.id().required(),
341+
scoreCardId: joi.alternatives().try(joi.id().required(), joi.string().uuid().required()),
342342
submissionId: joi
343343
.string()
344344
.uuid()
@@ -371,7 +371,7 @@ patchReview.schema = {
371371
score: joi.score(),
372372
typeId: joi.string().uuid(),
373373
reviewerId: joi.alternatives().try(joi.id(), joi.string().uuid()),
374-
scoreCardId: joi.id(),
374+
scoreCardId: joi.alternatives().try(joi.id(), joi.string().uuid()),
375375
submissionId: joi.string().uuid(),
376376
status: joi.reviewStatus(),
377377
metadata: joi.object(),

src/services/ReviewSummationService.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function * listReviewSummations (query) {
5959
}
6060

6161
const listReviewSummationsQuerySchema = {
62-
scoreCardId: joi.id(),
62+
scoreCardId: joi.alternatives().try(joi.id(), joi.string().uuid()),
6363
submissionId: joi.string().uuid(),
6464
aggregateScore: joi.score(),
6565
isPassing: joi.boolean(),
@@ -138,7 +138,7 @@ function * createReviewSummation (authUser, entity) {
138138
createReviewSummation.schema = {
139139
authUser: joi.object().required(),
140140
entity: joi.object().keys({
141-
scoreCardId: joi.id().required(),
141+
scoreCardId: joi.alternatives().try(joi.id().required(), joi.string().uuid().required()),
142142
submissionId: joi.string().uuid().required(),
143143
aggregateScore: joi.score().required(),
144144
isPassing: joi.boolean().required(),
@@ -263,7 +263,7 @@ updateReviewSummation.schema = {
263263
authUser: joi.object().required(),
264264
reviewSummationId: joi.string().uuid().required(),
265265
entity: joi.object().keys({
266-
scoreCardId: joi.id().required(),
266+
scoreCardId: joi.alternatives().try(joi.id().required(), joi.string().uuid().required()),
267267
submissionId: joi.string().uuid().required(),
268268
aggregateScore: joi.score().required(),
269269
isPassing: joi.boolean().required(),
@@ -288,7 +288,7 @@ patchReviewSummation.schema = {
288288
authUser: joi.object().required(),
289289
reviewSummationId: joi.string().uuid().required(),
290290
entity: joi.object().keys({
291-
scoreCardId: joi.id(),
291+
scoreCardId: joi.alternatives().try(joi.id(), joi.string().uuid()),
292292
submissionId: joi.string().uuid(),
293293
aggregateScore: joi.score(),
294294
isPassing: joi.boolean(),

0 commit comments

Comments
 (0)