Skip to content

Commit 7bd10ff

Browse files
authored
MINOR: Make data in FetchSnapshotRequest and FetchSnapshotRespponse private (apache#9820)
Reviewers: José Armando García Sancio <[email protected]>, David Jacot <[email protected]>
1 parent 462be6d commit 7bd10ff

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

clients/src/main/java/org/apache/kafka/common/requests/FetchSnapshotRequest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@
1616
*/
1717
package org.apache.kafka.common.requests;
1818

19-
import java.nio.ByteBuffer;
20-
import java.util.Collections;
21-
import java.util.Optional;
22-
import java.util.function.UnaryOperator;
2319
import org.apache.kafka.common.TopicPartition;
2420
import org.apache.kafka.common.message.FetchSnapshotRequestData;
2521
import org.apache.kafka.common.message.FetchSnapshotResponseData;
2622
import org.apache.kafka.common.protocol.ApiKeys;
27-
import org.apache.kafka.common.protocol.ApiMessage;
2823
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2924
import org.apache.kafka.common.protocol.Errors;
3025

26+
import java.nio.ByteBuffer;
27+
import java.util.Collections;
28+
import java.util.Optional;
29+
import java.util.function.UnaryOperator;
30+
3131
final public class FetchSnapshotRequest extends AbstractRequest {
32-
public final FetchSnapshotRequestData data;
32+
private final FetchSnapshotRequestData data;
3333

3434
public FetchSnapshotRequest(FetchSnapshotRequestData data, short version) {
3535
super(ApiKeys.FETCH_SNAPSHOT, version);
@@ -46,7 +46,7 @@ public FetchSnapshotResponse getErrorResponse(int throttleTimeMs, Throwable e) {
4646
}
4747

4848
@Override
49-
public ApiMessage data() {
49+
public FetchSnapshotRequestData data() {
5050
return data;
5151
}
5252

clients/src/main/java/org/apache/kafka/common/requests/FetchSnapshotResponse.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,25 +16,24 @@
1616
*/
1717
package org.apache.kafka.common.requests;
1818

19+
import org.apache.kafka.common.TopicPartition;
20+
import org.apache.kafka.common.message.FetchSnapshotResponseData;
21+
import org.apache.kafka.common.protocol.ApiKeys;
22+
import org.apache.kafka.common.protocol.ByteBufferAccessor;
23+
import org.apache.kafka.common.protocol.Errors;
24+
1925
import java.nio.ByteBuffer;
2026
import java.util.Collections;
2127
import java.util.HashMap;
2228
import java.util.Map;
2329
import java.util.Optional;
2430
import java.util.function.UnaryOperator;
25-
import org.apache.kafka.common.TopicPartition;
26-
import org.apache.kafka.common.message.FetchSnapshotResponseData;
27-
import org.apache.kafka.common.protocol.ApiKeys;
28-
import org.apache.kafka.common.protocol.ApiMessage;
29-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
30-
import org.apache.kafka.common.protocol.Errors;
3131

3232
final public class FetchSnapshotResponse extends AbstractResponse {
33-
public final FetchSnapshotResponseData data;
33+
private final FetchSnapshotResponseData data;
3434

3535
public FetchSnapshotResponse(FetchSnapshotResponseData data) {
3636
super(ApiKeys.FETCH_SNAPSHOT);
37-
3837
this.data = data;
3938
}
4039

@@ -63,7 +62,7 @@ public int throttleTimeMs() {
6362
}
6463

6564
@Override
66-
public ApiMessage data() {
65+
public FetchSnapshotResponseData data() {
6766
return data;
6867
}
6968

0 commit comments

Comments
 (0)