Update Criterion to 2.4

[hobovsky]

• Package name: Criterion
• Language name: C, used also for NASM
• Website:
  • repository: https://github.com/Snaipe/Criterion
  • docs: https://criterion.readthedocs.io/en/master/index.html

Criterion 2.4 was released Feb 2022 and has some changes in assertions API, which now extensively uses metaprogramming features and can potentially result in better code (but that's to be verified). I do not see any real advantage in terms of Codewars kata, other than maybe the fact that now official docs describe 2.4 assertions, and reference of assertions for the version currently used by Codewars is more difficult to find (they're hidden behind a link in a deprecation note: https://criterion.readthedocs.io/en/master/assert_old.html#old-assertions-ref).

---

👍 reaction might help to get this request prioritized.

[kazk]

I'm planning to add C++20 with the latest compiler sometime soon (#113). We can add a new C version at the same time with new Criterion.

For NASM, we can add a new version (#131) with new Criterion, and also enable preloaded.

---

Weren't you doing something with new Criterion earlier this year? I remember something on Discord.

[hobovsky]

I thought that Criterion 2.4 could be backwards compatible with whatever version is used now and could "just be updated", but I did not check and maybe it's not.

Weren't you doing something with new Criterion earlier this year? I remember something on Discord.

I was working on a Codewars reporter for Criterion which would not spam green logs on every assertion, but for some reason you did not decide to use it. I think it might be related to the fact that we did not manage to get it group logs from solution function with test case headers properly (as mentioned in this Discord thread). But still I was working with Codewars version, and not with the latest published one.

[kazk]

I forgot we merged it. codewars/criterion-hooks#1

Yeah, I think I was planning to look into the logs not synced only when testing inside a container, and got busy.

Criterion 2.4.1 has multiple breaking changes. I can't find a way to get our output while hiding the default report because the quiet mode (-q) changed.