Merge pull request #28 from comet-ml/DT-523-vpc-s3-endpoint

DT-523 add vpc s3 endpoint resource

Author: christopher-comet

.terraform.lock.hcl

@@ -15,6 +15,7 @@ module "comet_vpc" {
   source      = "./modules/comet_vpc"
   count       = var.enable_vpc ? 1 : 0
   environment = var.environment
+  region      = var.region
 
   eks_enabled        = var.enable_eks
   single_nat_gateway = var.single_nat_gateway

main.tf

@@ -39,4 +39,15 @@ module "vpc" {
   private_subnet_tags = var.eks_enabled ? { "kubernetes.io/role/internal-elb" = 1 } : null
 
   tags = local.tags
+}
+
+resource "aws_vpc_endpoint" "s3" {
+  vpc_id = module.vpc.vpc_id
+  service_name = "com.amazonaws.${var.region}.s3"
+  vpc_endpoint_type = "Gateway"
+  route_table_ids   = concat(module.vpc.private_route_table_ids, module.vpc.public_route_table_ids)
+  tags = merge(
+    local.tags,
+    { Name = "${local.resource_name}-s3-endpoint" }
+  )
 }

modules/comet_vpc/main.tf

@@ -11,4 +11,9 @@ variable "eks_enabled" {
 variable "single_nat_gateway" {
   description = "Controls whether single NAT gateway used for all public subnets"
   type        = bool
+}
+
+variable "region" {
+  description = "AWS region to provision resources in"
+  type        = string
 }

modules/comet_vpc/variables.tf

@@ -258,7 +258,7 @@ variable "elasticache_engine" {
 variable "elasticache_engine_version" {
   description = "Version number for ElastiCache engine"
   type        = string
-  default     = "7.1.0"
+  default     = "7.1"
 }
 
 variable "elasticache_instance_type" {
@@ -270,7 +270,7 @@ variable "elasticache_instance_type" {
 variable "elasticache_param_group_name" {
   description = "Name for the ElastiCache cluster parameter group"
   type        = string
-  default     = "default.redis5.0"
+  default     = "default.redis7"
 }
 
 variable "elasticache_num_cache_nodes" {