Improve the error message when running nested inside a non-Toolbx container

Fixes issue #1183

Signed-off-by: Nieves Montero <[email protected]>

Author: nievesmontero

src/cmd/root.go

@@ -144,6 +144,10 @@ func preRun(cmd *cobra.Command, args []string) error {
 		}
 	}
 
+	if utils.IsInsideContainer() && !utils.IsInsideToolboxContainer() {
+		return createErrorNonToolboxContainer()
+	}
+
 	toolboxPath := os.Getenv("TOOLBOX_PATH")
 
 	if toolboxPath == "" {

src/cmd/utils.go

@@ -138,6 +138,16 @@ func createErrorInvalidRelease(hint string) error {
 	return errors.New(errMsg)
 }
 
+func createErrorNonToolboxContainer() error {
+	var builder strings.Builder
+	fmt.Fprintf(&builder, "this is not a Toolbox container.\n")
+	fmt.Fprintf(&builder, "Toolbox is only meant to work with Toolbox containers.\n")
+	fmt.Fprintf(&builder, "Run '%s --help' for usage.", executableBase)
+
+	errMsg := builder.String()
+	return errors.New(errMsg)
+}
+
 func getUsageForCommonCommands() string {
 	var builder strings.Builder
 	fmt.Fprintf(&builder, "create    Create a new toolbox container\n")

test/system/104-run.bats

@@ -20,7 +20,6 @@ load 'libs/bats-assert/load'
 load 'libs/helpers'
 
 setup() {
-  bats_require_minimum_version 1.7.0
   _setup_environment
   cleanup_containers
 }