process: calling start_kill on exited child should not fail (tokio-rs#7160)

stepancheg · web-flow · commit 8e134172dd43 · 2025-02-15T13:48:22.000+03:30
diff --git a/tokio/src/process/mod.rs b/tokio/src/process/mod.rs
@@ -1158,10 +1158,7 @@ impl Child {
     pub fn start_kill(&mut self) -> io::Result<()> {
         match &mut self.child {
             FusedChild::Child(child) => child.kill(),
-            FusedChild::Done(_) => Err(io::Error::new(
-                io::ErrorKind::InvalidInput,
-                "invalid argument: can't kill an exited process",
-            )),
+            FusedChild::Done(_) => Ok(()),
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1158,10 +1158,7 @@ impl Child {`
`1158`	`1158`	`pub fn start_kill(&mut self) -> io::Result<()> {`
`1159`	`1159`	`match &mut self.child {`
`1160`	`1160`	`FusedChild::Child(child) => child.kill(),`
`1161`		`- FusedChild::Done(_) => Err(io::Error::new(`
`1162`		`- io::ErrorKind::InvalidInput,`
`1163`		`- "invalid argument: can't kill an exited process",`
`1164`		`- )),`
	`1161`	`+ FusedChild::Done(_) => Ok(()),`
`1165`	`1162`	`}`
`1166`	`1163`	`}`
`1167`	`1164`