fix: make HMR working again with latest vite version #999
Conversation
🦋 Changeset detectedLatest commit: b93dcd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is an automated message. Please do not reply to this comment. |
FliPPeDround
added
awaiting-feedback
|
Svelte content scripts E2E tests fails but looking into it ;-) It take more-than-expected to render broken image and results differs. Other than that everything works as expected (even for vite 3.x). |
|
In d6fc56c the image is removed from Svelte tests (as well as the check for the image). It changes the test, but makes it more stable. |
* replace google.com with example.com * remove broken image from svelte content-script tests to make tests more stable Changes pulled from crxjs#999
Fixing HMR with latest version of the Vite (>=6.0.9, >=5.4.12, <6.0.0, >=4.5.6, <5.0.0) - passing web socket token. Changes based on comment from vite dev (crxjs#971 (comment)) - passing config.webSocketToken to hmr-client-worker.ts under the key __HMR_TOKEN__.
elwin013
force-pushed
the
fix/pass-hmr-token-to-make-hmr-working-again-with-latest-vite-versions
branch
from
b93dcd1 to
a336cdf
Compare
|
Rebased over the latest |
Fixing HMR with latest version of the Vite (
>=6.0.9,>=5.4.12, <6.0.0,>=4.5.6, <5.0.0) - passing web socket token.Changes based on comment from vite dev (#971 (comment)) - passing
config.webSocketTokentohmr-client-worker.tsunder the key__HMR_TOKEN__.Closes #971