fix: do not use loader for contents scripts that have no imports #997
+161
−382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24f99d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is an automated message. Please do not reply to this comment. |
refi93
changed the title
refi93
changed the title
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
5ee6754 to
2ae977a
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
2ae977a to
6148d15
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
6148d15 to
82f9c85
Compare
refi93
commented
Apr 1, 2025
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
e8700e9 to
6629d0e
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
6629d0e to
69b30f4
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
69b30f4 to
bc06235
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
bc06235 to
69209bb
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
69209bb to
0921ff9
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
0921ff9 to
b595737
Compare
Toumash
requested changes
Apr 2, 2025
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
4611cfd to
794b97d
Compare
fixed 👍 77abfa8 |
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
794b97d to
77abfa8
Compare
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
21cabd3 to
c1db3a3
Compare
refi93
commented
Apr 4, 2025
...es/vite-plugin/tests/e2e/mv3-vite-svelte-content-script/__image_snapshots__/vite-build-0.png
Outdated
Show resolved
Hide resolved
Toumash
reviewed
Apr 4, 2025
packages/vite-plugin/tests/out/vite-svelte/__snapshots__/serve.test.ts.snap
Outdated
Show resolved
Hide resolved
Toumash
reviewed
Apr 4, 2025
packages/vite-plugin/tests/out/with-sourcemaps/__snapshots__/build.test.ts.snap
Show resolved
Hide resolved
Toumash
reviewed
Apr 4, 2025
packages/vite-plugin/tests/out/vite-react-fast-refresh/__snapshots__/serve.test.ts.snap
Outdated
Show resolved
Hide resolved
Toumash
reviewed
Apr 4, 2025
...ges/vite-plugin/tests/out/vite-content-script-css-imports-2/__snapshots__/build.test.ts.snap
Show resolved
Hide resolved
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
f6755cc to
b0a38d9
Compare
Toumash
reviewed
Apr 7, 2025
...es/vite-plugin/tests/e2e/mv3-vite-svelte-content-script/__image_snapshots__/vite-build-0.png
Outdated
Show resolved
Hide resolved
Toumash
requested changes
Apr 7, 2025
There was a problem hiding this comment.
👍 IMO ok
but not ready to be merged yet tho
we need to either:
- wait for the fix: make HMR working again with latest vite version #999 to merge to have the image snapshot tests resolved
- apply the same fixes in this PR
- ➡️create a separate PR that resolves the image snapshots first (so we'll not block any other PRs and will be super easy to merge)
Lets create a separate PR #1001 and wait for it to merge
|
ok, tests were fixed in #1001. |
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
b0a38d9 to
0092f61
Compare
Motivation: wrapping in IIFE may delay script injection, which is a needless tradeoff if the script has no (ES module) imports inspired by https://github.com/samrum/vite-plugin-web-extension/blob/main/src/utils/loader.ts#L57-L66
refi93
force-pushed
the
fix-content-script-without-imports
branch
from
0092f61 to
24f99d5
Compare
Toumash
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: content script loader may delay script injection, which is a needless tradeoff if the script has no (ES module) imports
inspired by https://github.com/samrum/vite-plugin-web-extension/blob/main/src/utils/loader.ts#L57-L66
closes #996