PR feedback - fix schema descriptions

Author: landonshumway-ia

backend/compact-connect/lambdas/python/purchases/purchase_client.py

@@ -846,7 +846,7 @@ class PaymentProcessorClientFactory:
     @staticmethod
     def create_payment_processor_client(credentials: dict) -> PaymentProcessorClient:
         processor_type: str = credentials.get('processor')
-        if processor_type.lower() == PaymentProcessorType.AUTHORIZE_DOT_NET_TYPE:
+        if processor_type.lower() == PaymentProcessorType.AUTHORIZE_DOT_NET_TYPE.lower():
             return AuthorizeNetPaymentProcessorClient(
                 api_login_id=credentials.get('api_login_id'), transaction_key=credentials.get('transaction_key')
             )

backend/compact-connect/stacks/api_stack/v1_api/api_model.py

@@ -687,12 +687,12 @@ def post_purchase_privileges_request_model(self) -> Model:
                                 properties={
                                     'dataDescriptor': JsonSchema(
                                         type=JsonSchemaType.STRING,
-                                        description='The card number',
+                                        description='The opaque data descriptor returned by Authorize.Net Accept UI',
                                         max_length=100,
                                     ),
                                     'dataValue': JsonSchema(
                                         type=JsonSchemaType.STRING,
-                                        description='The card expiration date',
+                                        description='The opaque data value token returned by Authorize.Net Accept UI',
                                         max_length=1000,
                                     ),
                                 },

backend/compact-connect/tests/app/test_api/test_purchases_api.py

@@ -139,7 +139,7 @@ def test_synth_generates_post_purchases_privileges_endpoint_resources(self):
         self.compare_snapshot(
             actual=post_purchase_privilege_request_model['Schema'],
             snapshot_name='PURCHASE_PRIVILEGE_REQUEST_SCHEMA',
-            overwrite_snapshot=True,
+            overwrite_snapshot=False,
         )
 
         # now check the response matches expected contract

backend/compact-connect/tests/resources/snapshots/PURCHASE_PRIVILEGE_REQUEST_SCHEMA.json

@@ -79,12 +79,12 @@
         "opaqueData": {
           "properties": {
             "dataDescriptor": {
-              "description": "The card number",
+              "description": "The opaque data descriptor returned by Authorize.Net Accept UI",
               "maxLength": 100,
               "type": "string"
             },
             "dataValue": {
-              "description": "The card expiration date",
+              "description": "The opaque data value token returned by Authorize.Net Accept UI",
               "maxLength": 1000,
               "type": "string"
             }