Should we include the workspace root lockfile in git? #65
Closed
romainmenke
started this conversation in
General
Replies: 1 comment 1 reply
-
@romainmenke I think this makes sense, especially with the issue we've had with TS. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
see : https://github.com/csstools/postcss-plugins/projects/1#card-74561431
The current release process is overcomplicated to ensure builds are correct.
node_modules
npm install
If we include
package-lock.json
from the workspace root in git it would become :npm ci
An added benefit of checking in
package-lock.json
is that builds would become reproducible.At the moment it is not possible to go back in git to a previous release and build everything exactly as it was build for that release.
package-lock.json
is never included when publishing to npm so it would not impact anything for users.Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions