Skip to content

[v1.2.16] Trino driver is broken #9303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Priyansh121096 opened this issue Mar 5, 2025 · 3 comments
Open

[v1.2.16] Trino driver is broken #9303

Priyansh121096 opened this issue Mar 5, 2025 · 3 comments
Assignees
@igorlukanin
Labels
driver:trino Issues relating to the Trino driver question The issue is a question. Please use Stack Overflow for questions.

Comments

@Priyansh121096
Copy link

Describe the bug
#9109 seems to have broken the Trino driver. This is because the Trino driver internally uses the PrestoDB driver and Trino does not have a /v1/node REST API similar to PrestoDB.

The same works with v1.1.16 which was the latest release which didn't include #9109.

To Reproduce
Steps to reproduce the behavior:

  1. Try hitting a Trino connection from the Playground with v1.2.16.
  2. See error:
Error: node list api returns error:<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 403 Forbidden</title>
</head>
<body>
<h2>HTTP ERROR 403 Forbidden</h2>
<table>
<tr><th>URI:</th><td>https://your.trino.host.com/v1/node</td></tr>
<tr><th>STATUS:</th><td>403</td></tr>
<tr><th>MESSAGE:</th><td>Forbidden</td></tr>
</table>

</body>
</html>

Expected behavior
Trino driver should work as expected.

Version:
[e.g. 1.2.16]
@igorlukanin igorlukanin added bug Something isn't working driver:trino Issues relating to the Trino driver question The issue is a question. Please use Stack Overflow for questions. and removed bug Something isn't working labels Mar 16, 2025
@igorlukanin
Copy link
Member

Hi @Priyansh121096 👋

Trino does not have a /v1/node REST API similar to PrestoDB.

Are you sure? I see /v1/node mentioned here in Trino docs: https://trino.io/docs/current/release/release-0.54.html

@igorlukanin igorlukanin self-assigned this Mar 16, 2025
@Priyansh121096
Copy link
Author

Hi @Priyansh121096 👋

Trino does not have a /v1/node REST API similar to PrestoDB.

Are you sure? I see /v1/node mentioned here in Trino docs: https://trino.io/docs/current/release/release-0.54.html

Ah, thanks for pointing this out @igorlukanin. It may be that the trino instance I'm using does not allow me to hit this endpoint.

@allekai
Copy link

allekai commented Apr 4, 2025

This issue affects us as well. In our case, it seems we won't get the permission on the /v1/node endpoint.

@igorlukanin As I understand, this request is made to test the connection. To me it seems that most of the other data source drivers use a SELECT 1 to check the connection. Wouldn't that make sense for the Trino driver as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorlukanin igorlukanin

Labels
driver:trino Issues relating to the Trino driver question The issue is a question. Please use Stack Overflow for questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@igorlukanin @allekai @Priyansh121096