Skip to content

Commit 2f802ec

Browse files
Use IntallPlugin rathern than AfterConfiguration hook (#52)
* Use IntallPlugin rathern than AfterConfiguration * Avoid usage of InstallPlugin if it is not defined
1 parent 756fb1d commit 2f802ec

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
1010

1111
## [Unreleased]
1212

13+
### Changed
14+
15+
- Use the new `InstallPlugin` hook rather than `AfterConfiguration`.
16+
([#52](https://github.com/cucumber/cucumber-ruby-wire/pull/52))
17+
1318
## [6.1.0]
1419
### Added
1520
- The possibility to verify if the plugin has already been installed or not. To

UPGRADING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
# Upgrading from 6.0.1 to 6.1.0
22

33
Usage of **built-in** wire protocol with `cucumber-ruby` will be deprecated in cucumber
4-
8.0.0, and removed in cucumber 9.0.0.
4+
7.1.0, and removed in cucumber 8.0.0.
55

66
The wire protocol will still be available by explicitely using the `cucumber-wire`
77
gem.
88

9-
### Before cucumber 8.0.0
9+
### Before cucumber 7.1.0
1010

1111
Before cucumber 7.1.0, the wire protocol was automatically installed with cucumber,
1212
and automatically activated when it had detected a `.wire` file.
1313

14-
### With cucumber 8.0.0
14+
### With cucumber 7.1.0
1515

1616
The wire protocol will work as before, but you will notice a deprecation message.
1717

@@ -46,8 +46,8 @@ require 'cucumber/wire'
4646

4747
The wire protocol will be installed, and no deprecation message will be shown anymore.
4848

49-
### With cucumber 9.0.0
49+
### With cucumber 8.0.0
5050

5151
The usage of the built-in wire protocol will be removed. You will have to install
5252
`cucumber-wire` and add `require 'cucumber/wire'` in your support code in order
53-
to continue using it, as explained [above](#with-cucumber-800).
53+
to continue using it, as explained [above](#with-cucumber-710).

cucumber.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
default: --format progress
1+
default: --format progress --publish-quiet

lib/cucumber/wire.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
require 'cucumber/wire/plugin'
22

3-
AfterConfiguration do |config, registry|
3+
return unless respond_to?(:InstallPlugin)
4+
5+
InstallPlugin do |config, registry|
46
Cucumber::Wire::Plugin.new(config, registry).install
57
end

0 commit comments

Comments
 (0)