build: update to nodejs rules 0.41.0 (angular#33996)

This bring is changes to the @nodejs repository required for angular#33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.

rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.

Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.

PR Close angular#33996

Author: gregmagolan

WORKSPACE

@@ -8,8 +8,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 # Fetch rules_nodejs so we can install our npm dependencies
 http_archive(
     name = "build_bazel_rules_nodejs",
-    sha256 = "9901bc17138a79135048fb0c107ee7a56e91815ec6594c08cb9a17b80276d62b",
-    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.40.0/rules_nodejs-0.40.0.tar.gz"],
+    sha256 = "8dc1466f8563f3aa4ac7ab7aa3c96651eb7764108219f40b2d1c918e1a81c601",
+    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.41.0/rules_nodejs-0.41.0.tar.gz"],
 )
 
 # Check the bazel version and download npm dependencies
@@ -29,7 +29,7 @@ Try running `yarn bazel` instead.
     minimum_bazel_version = "1.1.0",
 )
 
-check_rules_nodejs_version(minimum_version_string = "0.40.0")
+check_rules_nodejs_version(minimum_version_string = "0.41.0")
 
 # Setup the Node.js toolchain
 node_repositories(

modules/benchmarks/src/class_bindings/BUILD.bazel

@@ -41,12 +41,10 @@ ng_rollup_bundle(
 
 ts_devserver(
     name = "prodserver",
-    index_html = "index.html",
+    bootstrap = ["//packages/zone.js/dist:zone.js"],
     port = 4200,
-    static_files = [
-        ":bundle.min_debug.es2015.js",
-        "//packages/zone.js/dist:zone.js",
-    ],
+    static_files = ["index.html"],
+    deps = [":bundle.min_debug.es2015.js"],
 )
 
 benchmark_test(

modules/benchmarks/src/class_bindings/index.html

@@ -20,6 +20,8 @@
   <h1>Class Binding Benchmark</h1>
   <app-component>Loading...</app-component>
 
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 
 </html>

modules/benchmarks/src/expanding_rows/BUILD.bazel

@@ -42,31 +42,22 @@ ng_rollup_bundle(
 
 ts_devserver(
     name = "prodserver",
-    index_html = "index.html",
+    bootstrap = ["//packages/zone.js/dist:zone.js"],
     port = 4200,
-    static_files = [
-        "//packages/zone.js/dist:zone.js",
-    ],
-    deps = [
-        ":bundle.min_debug.es2015.js",
-    ],
+    static_files = ["index.html"],
+    deps = [":bundle.min_debug.es2015.js"],
 )
 
 ts_devserver(
     name = "devserver",
+    bootstrap = ["//packages/zone.js/dist:zone.js"],
     entry_module = "angular/modules/benchmarks/src/expanding_rows/index_aot",
-    # Uncomment this to run devserver. This is due to limitation of ts_devserver
-    # that produces `index.html` by default so there cannot be two ts_devserver
-    # rules in a single Bazel package.
-    # index_html = "index.html",
     port = 4200,
     scripts = [
         "@npm//:node_modules/tslib/tslib.js",
         "//tools/rxjs:rxjs_umd_modules",
     ],
-    static_files = [
-        "//packages/zone.js/dist:zone.js",
-    ],
+    static_files = ["index.html"],
     deps = [":application_lib"],
 )
 

modules/benchmarks/src/expanding_rows/index.html

@@ -12,6 +12,9 @@ <h1>Change Detection Benchmark</h1>
   <div id="rendererMode">...</div>
 
   <benchmark-root>Loading...</benchmark-root>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 
 </html>

modules/benchmarks/src/largeform/ng2/BUILD.bazel

@@ -26,17 +26,17 @@ ng_module(
 
 ts_devserver(
     name = "devserver",
+    bootstrap = [
+        "@npm//:node_modules/reflect-metadata/Reflect.js",
+        "//packages/zone.js/dist:zone.js",
+    ],
     entry_module = "angular/modules/benchmarks/src/largeform/ng2/index",
-    index_html = "index.html",
     port = 4200,
     scripts = [
         "@npm//:node_modules/tslib/tslib.js",
         "//tools/rxjs:rxjs_umd_modules",
     ],
-    static_files = [
-        "@npm//:node_modules/reflect-metadata/Reflect.js",
-        "//packages/zone.js/dist:zone.js",
-    ],
+    static_files = ["index.html"],
     tags = ["fixme-ivy-aot"],
     deps = [":ng2"],
 )

modules/benchmarks/src/largeform/ng2/index.html

@@ -19,5 +19,8 @@ <h2>Ng2 Large Form Benchmark</h2>
   <div>
     <app id="root">Loading...</app>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/largetable/baseline/BUILD.bazel

@@ -17,8 +17,8 @@ ts_library(
 ts_devserver(
     name = "devserver",
     entry_module = "angular/modules/benchmarks/src/largetable/baseline/index",
-    index_html = "index.html",
     port = 4200,
+    static_files = ["index.html"],
     deps = [":baseline"],
 )
 

modules/benchmarks/src/largetable/baseline/index.html

@@ -28,5 +28,8 @@ <h2>Baseline Largetable Benchmark</h2>
   <div>
     <largetable id="root">Loading...</largetable>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/largetable/incremental_dom/BUILD.bazel

@@ -17,9 +17,9 @@ ts_library(
 ts_devserver(
     name = "devserver",
     entry_module = "angular/modules/benchmarks/src/largetable/incremental_dom/index",
-    index_html = "index.html",
     port = 4200,
     static_files = [
+        "index.html",
         "@npm//:node_modules/incremental-dom/dist/incremental-dom.js",
     ],
     deps = [":incremental_dom"],

modules/benchmarks/src/largetable/incremental_dom/index.html

@@ -28,5 +28,9 @@ <h2>Incremental-Dom Largetable Benchmark</h2>
   <div>
     <largetable id="root"></largetable>
   </div>
+
+  <script src="/npm/node_modules/incremental-dom/dist/incremental-dom.js"></script>
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/largetable/iv/BUILD.bazel

@@ -5,9 +5,9 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
 ts_devserver(
     name = "devserver",
-    index_html = "index.html",
+    bootstrap = ["largetable.js"],
     port = 4200,
-    static_files = ["largetable.js"],
+    static_files = ["index.html"],
 )
 
 benchmark_test(

modules/benchmarks/src/largetable/iv/index.html

@@ -28,5 +28,8 @@ <h2>IV Largetable Benchmark</h2>
 <div>
   <largetable id="root"></largetable>
 </div>
+
+<!--default load location for ts_devserver-->
+<script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/largetable/ng2/BUILD.bazel

@@ -34,12 +34,10 @@ ng_rollup_bundle(
 
 ts_devserver(
     name = "prodserver",
-    index_html = "index.html",
+    bootstrap = ["//packages/zone.js/dist:zone.js"],
     port = 4200,
-    static_files = [
-        ":bundle.min_debug.es2015.js",
-        "//packages/zone.js/dist:zone.js",
-    ],
+    static_files = ["index.html"],
+    deps = [":bundle.min_debug.es2015.js"],
 )
 
 benchmark_test(

modules/benchmarks/src/largetable/ng2/index.html

@@ -28,5 +28,8 @@ <h2>Ng2 Largetable Benchmark</h2>
   <div>
     <largetable id="root">Loading...</largetable>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/largetable/ng2_switch/BUILD.bazel

@@ -22,17 +22,17 @@ ng_module(
 
 ts_devserver(
     name = "devserver",
+    bootstrap = [
+        "@npm//:node_modules/reflect-metadata/Reflect.js",
+        "//packages/zone.js/dist:zone.js",
+    ],
     entry_module = "angular/modules/benchmarks/src/largetable/ng2_switch/index",
-    index_html = "index.html",
     port = 4200,
     scripts = [
         "@npm//:node_modules/tslib/tslib.js",
         "//tools/rxjs:rxjs_umd_modules",
     ],
-    static_files = [
-        "@npm//:node_modules/reflect-metadata/Reflect.js",
-        "//packages/zone.js/dist:zone.js",
-    ],
+    static_files = ["index.html"],
     deps = [":ng2_switch"],
 )
 

modules/benchmarks/src/largetable/ng2_switch/index.html

@@ -28,5 +28,8 @@ <h2>Ng2 with NgSwitch Largetable Benchmark</h2>
   <div>
     <largetable id="root">Loading...</largetable>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/largetable/render3/BUILD.bazel

@@ -32,8 +32,8 @@ ng_rollup_bundle(
 
 ts_devserver(
     name = "devserver",
-    index_html = "index.html",
     port = 4200,
+    static_files = ["index.html"],
     tags = ["ivy-only"],
     deps = [
         ":bundle.min_debug.js",

modules/benchmarks/src/largetable/render3/index.html

@@ -28,6 +28,7 @@ <h2>Render3 Largetable Benchmark</h2>
     <largetable id="root"></largetable>
   </div>
 
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
-
 </html>

modules/benchmarks/src/tree/baseline/BUILD.bazel

@@ -17,8 +17,8 @@ ts_library(
 ts_devserver(
     name = "devserver",
     entry_module = "angular/modules/benchmarks/src/tree/baseline/index",
-    index_html = "index.html",
     port = 4200,
+    static_files = ["index.html"],
     deps = [":baseline"],
 )
 

modules/benchmarks/src/tree/baseline/index.html

@@ -25,5 +25,8 @@ <h2>Baseline Tree Benchmark</h2>
   <div>
     <tree id="root">Loading...</tree>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/tree/incremental_dom/BUILD.bazel

@@ -18,9 +18,9 @@ ts_library(
 ts_devserver(
     name = "devserver",
     entry_module = "angular/modules/benchmarks/src/tree/incremental_dom/index",
-    index_html = "index.html",
     port = 4200,
     static_files = [
+        "index.html",
         "@npm//:node_modules/incremental-dom/dist/incremental-dom.js",
     ],
     deps = [":incremental_dom"],

modules/benchmarks/src/tree/incremental_dom/index.html

@@ -25,5 +25,9 @@ <h2>Incremental-Dom Tree Benchmark</h2>
   <div>
     <tree id="root"></tree>
   </div>
+
+  <script src="/npm/node_modules/incremental-dom/dist/incremental-dom.js"></script>
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/tree/iv/BUILD.bazel

@@ -5,9 +5,9 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
 
 ts_devserver(
     name = "devserver",
-    index_html = "index.html",
+    bootstrap = ["tree.js"],
     port = 4200,
-    static_files = ["tree.js"],
+    static_files = ["index.html"],
 )
 
 benchmark_test(

modules/benchmarks/src/tree/iv/index.html

@@ -28,5 +28,8 @@ <h2>IV Tree Benchmark</h2>
     Change detection runs:<span id="numberOfChecks"></span>
   </div>
   <div id="root"></div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/tree/ng1/BUILD.bazel

@@ -16,12 +16,10 @@ ts_library(
 
 ts_devserver(
     name = "devserver",
+    bootstrap = ["@npm//:node_modules/angular/angular.js"],
     entry_module = "angular/modules/benchmarks/src/tree/ng1/index",
-    index_html = "index.html",
     port = 4200,
-    static_files = [
-        "@npm//:node_modules/angular/angular.js",
-    ],
+    static_files = ["index.html"],
     deps = [":ng1"],
 )
 

modules/benchmarks/src/tree/ng1/index.html

@@ -30,5 +30,8 @@ <h2>Ng1 Tree Benchmark</h2>
   <div>
     <tree id="root" data="initData">Loading...</tree>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/tree/ng2/BUILD.bazel

@@ -34,12 +34,10 @@ ng_rollup_bundle(
 
 ts_devserver(
     name = "prodserver",
-    index_html = "index.html",
+    bootstrap = ["//packages/zone.js/dist:zone.js"],
     port = 4200,
-    static_files = [
-        ":bundle.min_debug.es2015.js",
-        "//packages/zone.js/dist:zone.js",
-    ],
+    static_files = ["index.html"],
+    deps = [":bundle.min_debug.es2015.js"],
 )
 
 benchmark_test(

modules/benchmarks/src/tree/ng2/index.html

@@ -30,5 +30,8 @@ <h2>Ng2 Tree Benchmark</h2>
   <div>
     <tree id="root">Loading...</tree>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>

modules/benchmarks/src/tree/ng2_next/BUILD.bazel

@@ -20,12 +20,12 @@ ts_library(
 ts_devserver(
     name = "devserver",
     entry_module = "angular/modules/benchmarks/src/tree/ng2_next/index",
-    index_html = "index.html",
     port = 4200,
     scripts = [
         "@npm//:node_modules/tslib/tslib.js",
         "//tools/rxjs:rxjs_umd_modules",
     ],
+    static_files = ["index.html"],
     deps = [":ng2_next"],
 )
 

modules/benchmarks/src/tree/ng2_next/index.html

@@ -30,5 +30,8 @@ <h2>Ng2 Next Tree Benchmark</h2>
   <div>
     <tree id="root">Loading...</tree>
   </div>
+
+  <!--default load location for ts_devserver-->
+  <script src="/_/ts_scripts.js"></script>
 </body>
 </html>