Skip to content

Commit 0634b90

Browse files
committed
Update log severity constants (#403)
1 parent ced25bf commit 0634b90

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

api/ApplicationSettings.md

-1
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ Accepted values - constants available in the cefpython module:
314314
* LOGSEVERITY_INFO
315315
* LOGSEVERITY_WARNING
316316
* LOGSEVERITY_ERROR (default)
317-
* LOGSEVERITY_ERROR_REPORT
318317
* LOGSEVERITY_DISABLE
319318

320319

src/cef_v59..v66_changes.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ NEW FEATURES
7171
------------
7272

7373
internal/cef_types.h
74-
- cef_log_severity_t: new key LOGSEVERITY_DEBUG
74+
+ cef_log_severity_t: new key LOGSEVERITY_DEBUG (no need to expose,
75+
same as LOGSEVERITY_VERBOSE, see code comments in setting.pyx
7576
- cef_settings_t:
7677
- background_color: OSR windows can set an ARGB background color
7778
- cef_path_key_t (informational only):

src/extern/cef/cef_types.pxd

+1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ cdef extern from "include/internal/cef_types.h":
115115
ctypedef enum cef_log_severity_t:
116116
LOGSEVERITY_DEFAULT,
117117
LOGSEVERITY_VERBOSE,
118+
LOGSEVERITY_DEBUG = LOGSEVERITY_VERBOSE,
118119
LOGSEVERITY_INFO,
119120
LOGSEVERITY_WARNING,
120121
LOGSEVERITY_ERROR,

src/settings.pyx

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ cimport cef_types
1212

1313
LOGSEVERITY_DEFAULT = cef_types.LOGSEVERITY_DEFAULT
1414
LOGSEVERITY_VERBOSE = cef_types.LOGSEVERITY_VERBOSE
15+
# LOGSEVERITY_DEBUG is not exposed, as it is the same
16+
# as LOGSEVERITY_VERBOSE, and because it would be confusing
17+
# as currently passing --debug arg to app causes it to
18+
# set logseverity to LOGSEVERITY_INFO. Verbose logseverity
19+
# contains too much information.
1520
LOGSEVERITY_INFO = cef_types.LOGSEVERITY_INFO
1621
LOGSEVERITY_WARNING = cef_types.LOGSEVERITY_WARNING
1722
LOGSEVERITY_ERROR = cef_types.LOGSEVERITY_ERROR

0 commit comments

Comments
 (0)