Skip to content

Commit 44a74ad

Browse files
committed
Remove OnBeforeNavigation callback in renderer process (#403)
1 parent 9398d68 commit 44a74ad

File tree

3 files changed

+6
-19
lines changed

3 files changed

+6
-19
lines changed

src/cef_v59..v66_changes.txt

+6-4
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ BREAKAGE (needs updating Migration Guide doc)
2020
- + OnPrintJob new param
2121
- + OnPrintReset new param
2222

23-
cef_render_process_handler.h
24-
- Remove OnBeforeNavigation in subprocess/cefpython_app.h and .cpp files
23+
+ cef_render_process_handler.h
24+
- + Remove OnBeforeNavigation in subprocess/cefpython_app.h and .cpp files
2525

2626
cef_request_handler.h
2727
- OnBeforeBrowse: new param 'user_gesture'
28+
- update Migration Guide
2829

2930
internal/cef_linux.h
3031
internal/cef_types_linux.h
@@ -44,10 +45,11 @@ internal/cef_types_win.h
4445
internal/cef_types.h
4546
- cef_settings_t:
4647
- javascript_open_windows option removed (keep a dummy for BC)
48+
- update Migration Guide
4749
- cef_thread_id_t:
4850
- TID_DB removed (update Migration Guide)
49-
- TID_PROCESS_LAUNCHER removed
50-
- TID_CACHE removed
51+
- TID_PROCESS_LAUNCHER removed (update Migration Guide)
52+
- TID_CACHE removed (update Migration Guide)
5153

5254

5355
NEW FEATURES

src/subprocess/cefpython_app.cpp

-8
Original file line numberDiff line numberDiff line change
@@ -259,14 +259,6 @@ void CefPythonApp::OnBrowserDestroyed(CefRefPtr<CefBrowser> browser) {
259259
RemoveJavascriptBindings(browser);
260260
}
261261

262-
bool CefPythonApp::OnBeforeNavigation(CefRefPtr<CefBrowser> browser,
263-
CefRefPtr<CefFrame> frame,
264-
CefRefPtr<CefRequest> request,
265-
cef_navigation_type_t navigation_type,
266-
bool is_redirect) {
267-
return false;
268-
}
269-
270262
void CefPythonApp::OnContextCreated(CefRefPtr<CefBrowser> browser,
271263
CefRefPtr<CefFrame> frame,
272264
CefRefPtr<CefV8Context> context) {

src/subprocess/cefpython_app.h

-7
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,6 @@ class CefPythonApp :
7474
void OnBrowserDestroyed(CefRefPtr<CefBrowser> browser)
7575
override;
7676

77-
bool OnBeforeNavigation(CefRefPtr<CefBrowser> browser,
78-
CefRefPtr<CefFrame> frame,
79-
CefRefPtr<CefRequest> request,
80-
cef_navigation_type_t navigation_type,
81-
bool is_redirect)
82-
override;
83-
8477
void OnContextCreated(CefRefPtr<CefBrowser> browser,
8578
CefRefPtr<CefFrame> frame,
8679
CefRefPtr<CefV8Context> context)

0 commit comments

Comments
 (0)