Skip to content

Commit 9f86c42

Browse files
committed
When implementing custom cookie managers you must call FlushStore() (#365)
1 parent bff458e commit 9f86c42

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

api/RequestHandler.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ false.
8686

8787
Called on the IO thread before a resource is loaded. To allow the resource
8888
to load normally return None. To specify a handler for the resource return
89-
a [ResourceHandler](ResourceHandler.md) object. The |request| object should
89+
a [ResourceHandler](ResourceHandler.md) object. The |request| object should
9090
not be modified in this callback.
9191

9292
The [ResourceHandler](ResourceHandler.md) object is a python class that
@@ -215,6 +215,12 @@ to True. Otherwise the browser param passed to this callback will
215215
always be the same first browser that was created using
216216
[cefpython](cefpython.md).`CreateBrowserSync`.
217217

218+
**NOTE**: If implementing custom cookie managers you will encounter
219+
problems similar to [Issue #365](../../../issues/365) ("Cookies not
220+
flushed to disk when closing app immediately"). To resolve
221+
it you have to call CookieManager.[FlushStore](CookieManager.md#flushstore)
222+
method when closing associated browser.
223+
218224
Popup browsers created javascript's window.open share the same
219225
renderer process and request context. If you want to have separate
220226
cookie managers for popups created using window.open then you have

0 commit comments

Comments
 (0)