fix lint and comments

Author: Raphael Levin

bundle_size.js

@@ -1,5 +1,4 @@
 const fs = require('fs');
-const path = require('path');
 
 const newDistPath = './dist';
 const oldDistPath = './dist_old';

docs/api/vast-client.md

@@ -384,7 +384,7 @@ http://example.dailymotion.com/vast.php?domain=mywebsite.com
 */
 ```
 
-### removeURLTemplateFilter()
+### removeLastURLTemplateFilter()
 
 Removes the last element of the url templates filters array.
 

src/fetcher/fetcher.js

@@ -66,6 +66,8 @@ export class Fetcher {
    * @param {Object} params.wrapperAd - Previously parsed ad node (Wrapper) related to this fetching.
    * @param {Number} params.maxWrapperDepth - The maximum number of Wrapper that can be fetch
    * @param {Function} params.emitter - The function used to Emit event
+   * @emits  VASTParser#VAST-resolving
+   * @emits  VASTParser#VAST-resolved
    * @return {Promise}
    */
   fetchVAST({
@@ -76,46 +78,46 @@ export class Fetcher {
     previousUrl = null,
     wrapperAd = null,
   }) {
-    return new Promise(async (resolve, reject) => {
+    return new Promise((resolve, reject) => {
       const timeBeforeGet = Date.now();
 
       // Process url with defined filter
       this.URLTemplateFilters.forEach((filter) => {
         url = filter(url);
       });
 
-      try {
-        emitter('VAST-resolving', {
-          url,
-          previousUrl,
-          wrapperDepth,
-          maxWrapperDepth: maxWrapperDepth,
-          timeout: this.fetchingOptions.timeout,
-          wrapperAd,
-        });
+      emitter('VAST-resolving', {
+        url,
+        previousUrl,
+        wrapperDepth,
+        maxWrapperDepth,
+        timeout: this.fetchingOptions.timeout,
+        wrapperAd,
+      });
 
-        let data = await this.urlHandler.get(url, this.fetchingOptions);
-        const requestDuration = Math.round(Date.now() - timeBeforeGet);
+      this.urlHandler
+        .get(url, this.fetchingOptions)
+        .then((data) => {
+          const requestDuration = Math.round(Date.now() - timeBeforeGet);
 
-        emitter('VAST-resolved', {
-          url,
-          previousUrl,
-          wrapperDepth,
-          error: data?.error || null,
-          duration: requestDuration,
-          statusCode: data?.statusCode || null,
-          ...data?.details,
-        });
-        updateEstimatedBitrate(data?.details?.byteLength, requestDuration);
+          emitter('VAST-resolved', {
+            url,
+            previousUrl,
+            wrapperDepth,
+            error: data?.error || null,
+            duration: requestDuration,
+            statusCode: data?.statusCode || null,
+            ...data?.details,
+          });
+          updateEstimatedBitrate(data?.details?.byteLength, requestDuration);
 
-        if (data.error) {
-          reject(data.error);
-        } else {
-          resolve(data.xml);
-        }
-      } catch (error) {
-        reject(error);
-      }
+          if (data.error) {
+            reject(data.error);
+          } else {
+            resolve(data.xml);
+          }
+        })
+        .catch((error) => reject(error));
     });
   }
 }