Skip to content

Commit a2b779c

Browse files
committed
Spport icon new attributes
1 parent b00937d commit a2b779c

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

spec/creatives_parser.spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ describe('CreativesParser', function () {
4545
expect(icon.apiFramework).toEqual('VPAID');
4646
expect(icon.offset).toEqual(15);
4747
expect(icon.duration).toEqual(90);
48+
expect(icon.altText).toEqual("AltText");
49+
expect(icon.hoverText).toEqual("HoverText");
4850
expect(icon.type).toEqual('image/gif');
4951
expect(icon.staticResource).toEqual('http://example.com/linear-icon.gif');
5052
expect(icon.htmlResource).toBeNull();

spec/samples/creatives.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const creatives = `<Creatives>
4242
<Mezzanine id="mezzanine-id-165468451" type="video/mp4" width="1080" height="720" delivery="progressive" codec="h264" fileSize="700"><![CDATA[http://example.com/linear-mezzanine.mp4]]></Mezzanine>
4343
</MediaFiles>
4444
<Icons>
45-
<Icon program="ad1" width="60" height="20" xPosition="left" yPosition="bottom" duration="00:01:30.000" offset="00:00:15.000" apiFramework="VPAID" pxratio="2">
45+
<Icon altText="AltText" hoverText="HoverText" program="ad1" width="60" height="20" xPosition="left" yPosition="bottom" duration="00:01:30.000" offset="00:00:15.000" apiFramework="VPAID" pxratio="2">
4646
<StaticResource creativeType="image/gif"><![CDATA[http://example.com/linear-icon.gif]]></StaticResource>
4747
<IconViewTracking><![CDATA[http://example.com/linear-viewtracking]]></IconViewTracking>
4848
<IconClicks>
@@ -61,7 +61,7 @@ export const creatives = `<Creatives>
6161
<IconClickFallbackImage width="10px">
6262
<![CDATA[http://adserver.com/fallback.png]]>
6363
</IconClickFallbackImage>
64-
</IconClickFallbackImages>
64+
</IconClickFallbackImages>
6565
</IconClicks>
6666
</Icon>
6767
</Icons>

src/icon.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@ export function createIcon() {
1717
iconClickTrackingURLTemplates: [],
1818
iconViewTrackingURLTemplate: null,
1919
iconClickFallbackImages: [],
20+
altText: null,
21+
hoverText: null,
2022
};
2123
}

src/parser/creative_linear_parser.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,8 @@ function parseIcon(iconElement) {
271271
icon.duration = parserUtils.parseDuration(
272272
iconElement.getAttribute('duration')
273273
);
274+
icon.altText = iconElement.getAttribute('altText');
275+
icon.hoverText = iconElement.getAttribute('hoverText')
274276

275277
parserUtils
276278
.childrenByName(iconElement, 'HTMLResource')

0 commit comments

Comments
 (0)