diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml index 177cef9d7..879fb726d 100644 --- a/.github/workflows/health.yaml +++ b/.github/workflows/health.yaml @@ -8,7 +8,9 @@ jobs: health: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: - checks: "version,changelog,do-not-submit" + checks: "version,changelog,do-not-submit,breaking" + fail_on: "version,changelog,do-not-submit,breaking" + warn_on: "license,coverage,leaking" ignore_license: "**.g.dart" sdk: dev permissions: diff --git a/_test/lib/app.dart b/_test/lib/app.dart index 361b954ac..95079c455 100644 --- a/_test/lib/app.dart +++ b/_test/lib/app.dart @@ -4,8 +4,8 @@ import 'package:web/web.dart'; -void startApp({String? text}) { - text ??= 'Hello World!'; +void startApp({required String text}) { + // text ??= 'Hello World!'; var component = HTMLDivElement()..text = text; document.body!.append(component); } diff --git a/_test/test/hello_world_deferred_test.dart b/_test/test/hello_world_deferred_test.dart index ac61f9952..90515fa81 100644 --- a/_test/test/hello_world_deferred_test.dart +++ b/_test/test/hello_world_deferred_test.dart @@ -14,7 +14,7 @@ import 'package:web/web.dart'; import 'common/message.dart' deferred as m; void main() { - setUp(startApp); + setUp(() => startApp(text: 'Hello World!')); tearDown(() { document.body!.innerHTML = ''.toJS; diff --git a/_test/test/hello_world_test.dart b/_test/test/hello_world_test.dart index 8023208ed..31c89d726 100644 --- a/_test/test/hello_world_test.dart +++ b/_test/test/hello_world_test.dart @@ -16,7 +16,7 @@ import 'package:web/web.dart'; import 'common/message.dart'; void main() { - setUp(startApp); + setUp(() => startApp(text: 'Hello World!')); tearDown(() { document.body!.innerHTML = ''.toJS; diff --git a/build_web_compilers/CHANGELOG.md b/build_web_compilers/CHANGELOG.md index f402849ca..99334dccd 100644 --- a/build_web_compilers/CHANGELOG.md +++ b/build_web_compilers/CHANGELOG.md @@ -1,3 +1,5 @@ +## 4.2.0 + ## 4.1.0-beta.1 - Fix loading compiled modules from subdirectories. diff --git a/build_web_compilers/lib/builders.dart b/build_web_compilers/lib/builders.dart index efd5d7934..c530eb260 100644 --- a/build_web_compilers/lib/builders.dart +++ b/build_web_compilers/lib/builders.dart @@ -12,7 +12,7 @@ import 'src/sdk_js_compile_builder.dart'; import 'src/sdk_js_copy_builder.dart'; // Shared entrypoint builder -Builder webEntrypointBuilder(BuilderOptions options) => +Object webEntrypointBuilder(BuilderOptions options) => WebEntrypointBuilder.fromOptions(options); // Ddc related builders diff --git a/build_web_compilers/pubspec.yaml b/build_web_compilers/pubspec.yaml index 463b44383..e900e7683 100644 --- a/build_web_compilers/pubspec.yaml +++ b/build_web_compilers/pubspec.yaml @@ -1,5 +1,5 @@ name: build_web_compilers -version: 4.1.0-beta.1 +version: 4.2.0 description: Builder implementations wrapping the dart2js and DDC compilers. repository: https://github.com/dart-lang/build/tree/master/build_web_compilers # This package can't be part of the workspace because it requires a very recent