Skip to content

Commit f6e0a8f

Browse files
committed
Catch unexpected http uri error in service isolate
Fixes #24388 [email protected] Review URL: https://codereview.chromium.org//1357023004 .
1 parent 36f70ac commit f6e0a8f

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

runtime/bin/vmservice/server.dart

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,16 @@ class Server {
146146
return;
147147
}
148148
// HTTP based service request.
149-
var client = new HttpRequestClient(request, _service);
150-
var message = new Message.fromUri(client, request.uri);
151-
client.onMessage(null, message);
149+
try {
150+
var client = new HttpRequestClient(request, _service);
151+
var message = new Message.fromUri(client, request.uri);
152+
client.onMessage(null, message);
153+
} catch (e) {
154+
print('Unexpected error processing HTTP request uri: '
155+
'${request.uri}\n$e\n');
156+
rethrow;
157+
}
158+
152159
}
153160

154161
Future startup() {

0 commit comments

Comments
 (0)