Skip to content

Commit fba6645

Browse files
authored
Moved functions from ndimage submodules to ndimage namespace (#325)
* Moved functions from ndimage submodules to ndimage namespace * Updated minimum cupy versions required for cupy related tests
1 parent 91ea280 commit fba6645

File tree

8 files changed

+28
-28
lines changed

8 files changed

+28
-28
lines changed

dask_image/dispatch/_dispatch_ndfilters.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def register_cupy_convolve():
5656

5757
@dispatch_convolve.register(cupy.ndarray)
5858
def cupy_convolve(*args, **kwargs):
59-
return cupyx.scipy.ndimage.filters.convolve
59+
return cupyx.scipy.ndimage.convolve
6060

6161

6262
# ================== correlate ==================
@@ -72,7 +72,7 @@ def register_cupy_correlate():
7272

7373
@dispatch_correlate.register(cupy.ndarray)
7474
def cupy_correlate(*args, **kwargs):
75-
return cupyx.scipy.ndimage.filters.correlate
75+
return cupyx.scipy.ndimage.correlate
7676

7777

7878
# ================== laplace ==================
@@ -88,7 +88,7 @@ def register_cupy_laplace():
8888

8989
@dispatch_laplace.register(cupy.ndarray)
9090
def cupy_laplace(*args, **kwargs):
91-
return cupyx.scipy.ndimage.filters.laplace
91+
return cupyx.scipy.ndimage.laplace
9292

9393

9494
# ================== prewitt ==================
@@ -104,7 +104,7 @@ def register_cupy_prewitt():
104104

105105
@dispatch_prewitt.register(cupy.ndarray)
106106
def cupy_prewitt(*args, **kwargs):
107-
return cupyx.scipy.ndimage.filters.prewitt
107+
return cupyx.scipy.ndimage.prewitt
108108

109109

110110
# ================== sobel ==================
@@ -120,7 +120,7 @@ def register_cupy_sobel():
120120

121121
@dispatch_sobel.register(cupy.ndarray)
122122
def cupy_sobel(*args, **kwargs):
123-
return cupyx.scipy.ndimage.filters.sobel
123+
return cupyx.scipy.ndimage.sobel
124124

125125

126126
# ================== gaussian_filter ==================
@@ -136,7 +136,7 @@ def register_cupy_gaussian_filter():
136136

137137
@dispatch_gaussian_filter.register(cupy.ndarray)
138138
def cupy_gaussian_filter(*args, **kwargs):
139-
return cupyx.scipy.ndimage.filters.gaussian_filter
139+
return cupyx.scipy.ndimage.gaussian_filter
140140

141141

142142
# ================== gaussian_gradient_magnitude ==================
@@ -152,7 +152,7 @@ def register_cupy_gaussian_gradient_magnitude():
152152

153153
@dispatch_gaussian_gradient_magnitude.register(cupy.ndarray)
154154
def cupy_gaussian_gradient_magnitude(*args, **kwargs):
155-
return cupyx.scipy.ndimage.filters.gaussian_gradient_magnitude
155+
return cupyx.scipy.ndimage.gaussian_gradient_magnitude
156156

157157

158158
# ================== gaussian_laplace ==================
@@ -168,7 +168,7 @@ def register_cupy_gaussian_laplace():
168168

169169
@dispatch_gaussian_laplace.register(cupy.ndarray)
170170
def cupy_gaussian_laplace(*args, **kwargs):
171-
return cupyx.scipy.ndimage.filters.gaussian_laplace
171+
return cupyx.scipy.ndimage.gaussian_laplace
172172

173173

174174
# ================== generic_filter ==================
@@ -184,7 +184,7 @@ def register_cupy_generic_filter():
184184

185185
@dispatch_generic_filter.register(cupy.ndarray)
186186
def cupy_generic_filter(*args, **kwargs):
187-
return cupyx.scipy.ndimage.filters.generic_filter
187+
return cupyx.scipy.ndimage.generic_filter
188188

189189

190190
# ================== minimum_filter ==================
@@ -200,7 +200,7 @@ def register_cupy_minimum_filter():
200200

201201
@dispatch_minimum_filter.register(cupy.ndarray)
202202
def cupy_minimum_filter(*args, **kwargs):
203-
return cupyx.scipy.ndimage.filters.minimum_filter
203+
return cupyx.scipy.ndimage.minimum_filter
204204

205205

206206
# ================== median_filter ==================
@@ -216,7 +216,7 @@ def register_cupy_median_filter():
216216

217217
@dispatch_median_filter.register(cupy.ndarray)
218218
def cupy_median_filter(*args, **kwargs):
219-
return cupyx.scipy.ndimage.filters.median_filter
219+
return cupyx.scipy.ndimage.median_filter
220220

221221

222222
# ================== maximum_filter ==================
@@ -232,7 +232,7 @@ def register_cupy_maximum_filter():
232232

233233
@dispatch_maximum_filter.register(cupy.ndarray)
234234
def cupy_maximum_filter(*args, **kwargs):
235-
return cupyx.scipy.ndimage.filters.maximum_filter
235+
return cupyx.scipy.ndimage.maximum_filter
236236

237237

238238
# ================== rank_filter ==================
@@ -248,7 +248,7 @@ def register_cupy_rank_filter():
248248

249249
@dispatch_rank_filter.register(cupy.ndarray)
250250
def cupy_rank_filter(*args, **kwargs):
251-
return cupyx.scipy.ndimage.filters.rank_filter
251+
return cupyx.scipy.ndimage.rank_filter
252252

253253

254254
# ================== percentile_filter ==================
@@ -264,7 +264,7 @@ def register_cupy_percentile_filter():
264264

265265
@dispatch_percentile_filter.register(cupy.ndarray)
266266
def cupy_percentile_filter(*args, **kwargs):
267-
return cupyx.scipy.ndimage.filters.percentile_filter
267+
return cupyx.scipy.ndimage.percentile_filter
268268

269269

270270
# ================== uniform_filter ==================
@@ -280,7 +280,7 @@ def register_cupy_uniform_filter():
280280

281281
@dispatch_uniform_filter.register(cupy.ndarray)
282282
def cupy_uniform_filter(*args, **kwargs):
283-
return cupyx.scipy.ndimage.filters.uniform_filter
283+
return cupyx.scipy.ndimage.uniform_filter
284284

285285

286286
# ================== threshold_local_mean ==================

tests/test_dask_image/test_imread/test_cupy_imread.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import dask_image.imread
66

7-
cupy = pytest.importorskip("cupy", minversion="7.7.0")
7+
cupy = pytest.importorskip("cupy", minversion="6.0.0")
88

99

1010
@pytest.mark.cupy

tests/test_dask_image/test_ndfilters/test_cupy_ndfilters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import dask_image.ndfilters
99

10-
cupy = pytest.importorskip("cupy", minversion="7.7.0")
10+
cupy = pytest.importorskip("cupy", minversion="8.0.0")
1111

1212

1313
@pytest.fixture

tests/test_dask_image/test_ndfilters/test_cupy_threshold.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from dask_image.ndfilters import threshold_local
99

10-
cupy = pytest.importorskip("cupy", minversion="7.7.0")
10+
cupy = pytest.importorskip("cupy", minversion="5.0.0")
1111

1212

1313
@pytest.mark.parametrize('block_size', [

tests/test_dask_image/test_ndfourier/test_core.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_fourier_filter_err(funcname, err_type, s, n):
5858
)
5959
def test_fourier_filter_identity(funcname, s):
6060
da_func = getattr(dask_image.ndfourier, funcname)
61-
sp_func = getattr(scipy.ndimage.fourier, funcname)
61+
sp_func = getattr(scipy.ndimage, funcname)
6262

6363
a = np.arange(140.0).reshape(10, 14).astype(complex)
6464
d = da.from_array(a, chunks=(5, 7))
@@ -105,7 +105,7 @@ def test_fourier_filter_type(funcname, upcast_type, dtype):
105105
s = 1
106106

107107
da_func = getattr(dask_image.ndfourier, funcname)
108-
sp_func = getattr(scipy.ndimage.fourier, funcname)
108+
sp_func = getattr(scipy.ndimage, funcname)
109109

110110
a = np.arange(140.0).reshape(10, 14).astype(dtype)
111111
d = da.from_array(a, chunks=(5, 7))
@@ -147,7 +147,7 @@ def test_fourier_filter_chunks(funcname, shape, chunks):
147147
s = 1
148148

149149
da_func = getattr(dask_image.ndfourier, funcname)
150-
sp_func = getattr(scipy.ndimage.fourier, funcname)
150+
sp_func = getattr(scipy.ndimage, funcname)
151151

152152
a = np.arange(np.prod(shape)).reshape(shape).astype(dtype)
153153
d = da.from_array(a, chunks=chunks)
@@ -180,7 +180,7 @@ def test_fourier_filter_chunks(funcname, shape, chunks):
180180
)
181181
def test_fourier_filter_non_positive(funcname, s):
182182
da_func = getattr(dask_image.ndfourier, funcname)
183-
sp_func = getattr(scipy.ndimage.fourier, funcname)
183+
sp_func = getattr(scipy.ndimage, funcname)
184184

185185
a = np.arange(140.0).reshape(10, 14).astype(complex)
186186
d = da.from_array(a, chunks=(5, 7))
@@ -225,7 +225,7 @@ def test_fourier_filter_non_positive(funcname, s):
225225
)
226226
def test_fourier_filter(funcname, s, real_fft, axis):
227227
da_func = getattr(dask_image.ndfourier, funcname)
228-
sp_func = getattr(scipy.ndimage.fourier, funcname)
228+
sp_func = getattr(scipy.ndimage, funcname)
229229

230230
shape = (10, 14)
231231
n = 2 * shape[axis] - 1 if real_fft else -1

tests/test_dask_image/test_ndinterp/test_affine_transformation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def test_affine_transform_cupy(n,
155155
interp_order,
156156
input_output_chunksize_per_dim,
157157
random_seed):
158-
pytest.importorskip("cupy", minversion="6.0.0")
158+
pytest.importorskip("cupy", minversion="5.0.0")
159159

160160
kwargs = dict()
161161
kwargs['n'] = n
@@ -264,7 +264,7 @@ def test_affine_transform_type_consistency():
264264
@pytest.mark.cupy
265265
def test_affine_transform_type_consistency_gpu():
266266

267-
cupy = pytest.importorskip("cupy", minversion="6.0.0")
267+
cupy = pytest.importorskip("cupy", minversion="5.0.0")
268268

269269
image = da.ones((3, 3))
270270
image_t = dask_image.ndinterp.affine_transform(image, np.eye(2), [0, 0])
@@ -314,7 +314,7 @@ def test_affine_transform_large_input_small_output_gpu():
314314
"""
315315
Make sure input array does not need to be computed entirely
316316
"""
317-
cupy = pytest.importorskip("cupy", minversion="6.0.0")
317+
cupy = pytest.importorskip("cupy", minversion="5.0.0")
318318

319319
# this array would occupy more than 24GB on a GPU
320320
image = da.random.random([2000] * 3, chunks=(50, 50, 50))

tests/test_dask_image/test_ndinterp/test_spline_filter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def test_spline_filter_cupy(
143143
input_as_non_dask_array,
144144
):
145145

146-
pytest.importorskip("cupy", minversion="6.0.0")
146+
pytest.importorskip("cupy", minversion="9.0.0")
147147

148148
validate_spline_filter(
149149
n=n,

tests/test_dask_image/test_ndmorph/test_cupy_ndmorph.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import dask_image.ndmorph
99

10-
cupy = pytest.importorskip("cupy", minversion="7.7.0")
10+
cupy = pytest.importorskip("cupy", minversion="9.0.0")
1111

1212

1313
@pytest.fixture

0 commit comments

Comments
 (0)