Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit ff51131

Browse files
authored
Merge pull request #759 from datafold/issue_758
issue 758
2 parents 41148be + 4691cbe commit ff51131

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

data_diff/databases/bigquery.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,17 +193,18 @@ def __init__(self, project, *, dataset, bigquery_credentials=None, **kw):
193193
bigquery = import_bigquery()
194194

195195
keyfile = kw.pop("keyfile", None)
196+
impersonate_service_account = kw.pop("impersonate_service_account", None)
196197
if keyfile:
197198
bigquery_service_account = import_bigquery_service_account()
198199
credentials = bigquery_service_account.Credentials.from_service_account_file(
199200
keyfile,
200201
scopes=["https://www.googleapis.com/auth/cloud-platform"],
201202
)
202-
elif kw.get("impersonate_service_account"):
203+
elif impersonate_service_account:
203204
bigquery_service_account_impersonation = import_bigquery_service_account_impersonation()
204205
credentials = bigquery_service_account_impersonation.Credentials(
205206
source_credentials=credentials,
206-
target_principal=kw["impersonate_service_account"],
207+
target_principal=impersonate_service_account,
207208
target_scopes=["https://www.googleapis.com/auth/cloud-platform"],
208209
)
209210

0 commit comments

Comments
 (0)