Skip to content

Commit d6d9e58

Browse files
authored
perf: remove composable meta property class (#167)
1 parent 0120de6 commit d6d9e58

File tree

5 files changed

+30
-36
lines changed

5 files changed

+30
-36
lines changed

projects/ngx-meta/src/core/public-api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ export {
66
provideCore as provideNgxMetaCore,
77
withDefaults as withNgxMetaDefaults,
88
} from './src/provide-core'
9-
export * from './src/composable-meta-property'
109
export * from './src/global-metadata'
1110
export * from './src/global-metadata-image'
1211
export * from './src/global-metadata-key'
12+
export * from './src/make-composed-meta-property'
1313
export * from './src/make-global-metadata'
1414
export * from './src/make-metadata'
1515
export * from './src/meta-content'

projects/ngx-meta/src/core/src/composable-meta-property.ts

Lines changed: 0 additions & 25 deletions
This file was deleted.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { MetaProperty } from './meta-property'
2+
3+
type MetaPropertyOpts = ConstructorParameters<typeof MetaProperty>[0]
4+
type ComposedMetaPropertyOpts = Omit<MetaPropertyOpts, 'keyName'> & {
5+
separator?: string
6+
}
7+
8+
export const makeComposedMetaProperty = (
9+
opts: ComposedMetaPropertyOpts,
10+
names: ReadonlyArray<string>,
11+
) =>
12+
new MetaProperty({
13+
...opts,
14+
keyName: names.join(
15+
opts.separator ?? DEFAULT_COMPOSED_META_PROPERTY_SEPARATOR,
16+
),
17+
})
18+
19+
export const DEFAULT_COMPOSED_META_PROPERTY_SEPARATOR = ':'
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import {
2-
ComposableMetaProperty,
32
KEY_ATTRIBUTE_PROPERTY,
3+
makeComposedMetaProperty,
44
} from '@davidlj95/ngx-meta/core'
55

66
export const makeOpenGraphMetaProperty = (...names: string[]) =>
7-
new ComposableMetaProperty(
8-
{ keyAttr: KEY_ATTRIBUTE_PROPERTY },
9-
...['og', ...names],
10-
)
7+
makeComposedMetaProperty({ keyAttr: KEY_ATTRIBUTE_PROPERTY }, [
8+
'og',
9+
...names,
10+
])
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import {
2-
ComposableMetaProperty,
32
KEY_ATTRIBUTE_PROPERTY,
3+
makeComposedMetaProperty,
44
} from '@davidlj95/ngx-meta/core'
55

66
export const makeTwitterCardMetaProperty = (...names: string[]) =>
7-
new ComposableMetaProperty(
8-
{ keyAttr: KEY_ATTRIBUTE_PROPERTY },
9-
...['twitter', ...names],
10-
)
7+
makeComposedMetaProperty({ keyAttr: KEY_ATTRIBUTE_PROPERTY }, [
8+
'twitter',
9+
...names,
10+
])

0 commit comments

Comments
 (0)