-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dead link in ARCHITECTURE.md
#11475
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @cypherpepe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding and fixing this! ❤️ One small grammatical issue we should probably fix as well 🙏
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Co-authored-by: Quigley Malcolm <[email protected]>
Hi @QMalcolm! Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for doing this! 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11475 +/- ##
==========================================
- Coverage 88.91% 88.85% -0.07%
==========================================
Files 194 194
Lines 24553 24553
==========================================
- Hits 21832 21816 -16
- Misses 2721 2737 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Resolves #
Hi! I found a broken link in
ARCHITECTURE.md
- the current link to dbt-postgres points to the root of the dbt-adapters repo instead of the specific adapter directory. This could confuse new developers looking for the Postgres adapter source codProblem
...
Solution
Updated the link to point directly to the dbt-postgres directory within the dbt-adapters repo.
Checklist