Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dead link in ARCHITECTURE.md #11475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

cypherpepe
Copy link

Resolves #

Hi! I found a broken link in ARCHITECTURE.md - the current link to dbt-postgres points to the root of the dbt-adapters repo instead of the specific adapter directory. This could confuse new developers looking for the Postgres adapter source cod

Problem

...

Solution

Updated the link to point directly to the dbt-postgres directory within the dbt-adapters repo.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cypherpepe cypherpepe requested a review from a team as a code owner April 9, 2025 14:07
Copy link

cla-bot bot commented Apr 9, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @cypherpepe

@github-actions github-actions bot added the community This PR is from a community member label Apr 9, 2025
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this! ❤️ One small grammatical issue we should probably fix as well 🙏

@QMalcolm
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Apr 11, 2025
Copy link

cla-bot bot commented Apr 11, 2025

The cla-bot has been summoned, and re-checked this pull request!

Co-authored-by: Quigley Malcolm <[email protected]>
@cypherpepe cypherpepe requested a review from QMalcolm April 11, 2025 09:31
@cypherpepe
Copy link
Author

Hi @QMalcolm! Done

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for doing this! 🚀

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (e2e86b7) to head (2457122).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11475      +/-   ##
==========================================
- Coverage   88.91%   88.85%   -0.07%     
==========================================
  Files         194      194              
  Lines       24553    24553              
==========================================
- Hits        21832    21816      -16     
- Misses       2721     2737      +16     
Flag Coverage Δ
integration 85.85% <ø> (-0.15%) ⬇️
unit 62.77% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.77% <ø> (+0.03%) ⬆️
Integration Tests 85.85% <ø> (-0.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants