Behavior flag to handle all warnings with warn_error logic #11483
+80
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11116
Problem
Not all warnings are currently handled by
warn_error
. This is problematic, as our docs lead one to believe if they have--warn-error
or--warn-error-options={'error': 'all'}
that all warnings will become errors (docs). Unfortunately, we can't just make it such that all warnings are handled by thewarn_error
logic, as that means currently working projects which are using either of the flags I previously described would begin to fail.Solution
Add a behavior flag
require_all_warnings_handled_by_warn_error
which, if set toTrue
, will make it so all warnings are handled bywarn_error
logic. This is possible because of the work done in dbt-labs/dbt-common#259.Checklist