You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to suggest a change to implementation of AbstractSyncWebSocketClient.send method. It should return True if & only when the send() is succeeded. Why True is returned in case when websockets.exceptions.ConnectionClosedOK or websockets.exceptions.ConnectionClosed?
Maybe, I dont understand the sense of bool value returned by send, but for me if user (deepgram) didn't get any message I expect to get False
Proposed changes
I would like to suggest a change to implementation of
AbstractSyncWebSocketClient.send
method. It should return True if & only when the send() is succeeded. WhyTrue
is returned in case whenwebsockets.exceptions.ConnectionClosedOK
orwebsockets.exceptions.ConnectionClosed
?Maybe, I dont understand the sense of bool value returned by send, but for me if user (deepgram) didn't get any message I expect to get False
Context
File:
deepgram/clients/common/v1/abstract_sync_websocket.py
Class:
AbstractSyncWebSocketClient
Method:
send
Description:
Possible Implementation
Other information
The text was updated successfully, but these errors were encountered: