Skip to content

Commit ddad194

Browse files
alambion-elgreco
authored andcommitted
fix: restore unused code, mark with expect(dead_code)
Signed-off-by: Andrew Lamb <[email protected]>
1 parent ea37f1c commit ddad194

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

crates/core/src/kernel/models/fields.rs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,19 @@ static REMOVE_FIELD: LazyLock<StructField> = LazyLock::new(|| {
145145
true,
146146
)
147147
});
148+
// TODO implement support for this checkpoint
149+
#[expect(dead_code)]
150+
static REMOVE_FIELD_CHECKPOINT: LazyLock<StructField> = LazyLock::new(|| {
151+
StructField::new(
152+
"remove",
153+
StructType::new(vec![
154+
StructField::new("path", DataType::STRING, false),
155+
StructField::new("deletionTimestamp", DataType::LONG, true),
156+
StructField::new("dataChange", DataType::BOOLEAN, false),
157+
]),
158+
true,
159+
)
160+
});
148161
// https://github.com/delta-io/delta/blob/master/PROTOCOL.md#add-cdc-file
149162
static CDC_FIELD: LazyLock<StructField> = LazyLock::new(|| {
150163
StructField::new(

crates/core/src/operations/filesystem_check.rs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ use futures::future::BoxFuture;
2222
use futures::StreamExt;
2323
pub use object_store::path::Path;
2424
use object_store::ObjectStore;
25-
use serde::{Serialize, Serializer};
25+
use serde::{de::Error as DeError, Deserialize, Deserializer, Serialize, Serializer};
2626
use url::{ParseError, Url};
2727
use uuid::Uuid;
2828

@@ -79,6 +79,16 @@ where
7979
serializer.serialize_str(&json_string)
8080
}
8181

82+
// Custom deserialization that parses a JSON string into MetricDetails
83+
#[expect(dead_code)]
84+
fn deserialize_vec_string<'de, D>(deserializer: D) -> Result<Vec<String>, D::Error>
85+
where
86+
D: Deserializer<'de>,
87+
{
88+
let s: String = Deserialize::deserialize(deserializer)?;
89+
serde_json::from_str(&s).map_err(DeError::custom)
90+
}
91+
8292
fn is_absolute_path(path: &str) -> DeltaResult<bool> {
8393
match Url::parse(path) {
8494
Ok(_) => Ok(true),

0 commit comments

Comments
 (0)