Account for Basics when inserting foils

dev-id · web-flow · commit 667f276e0769 · 2017-05-12T22:01:18.000-05:00
According to [this article](http://www.mtgsalvation.com/forums/magic-fundamentals/magic-general/768235-what-are-current-pack-odds-including-foils) foil basics occur at a rate of approx 2/15. We'll discard those 2/15 and end up with 1/6.92 or approx 1/7 odds of getting a foil other than a basic land. Closes arxanas#8
diff --git a/src/pool.js b/src/pool.js
@@ -163,7 +163,8 @@ function toPack(code) {
       }
     }
   }
-  if (_.rand(6) < 1 && !(foilCard) && !(masterpiece)) {
+  if (_.rand(7) < 1 && !(foilCard) && !(masterpiece)) {
+    // http://www.mtgsalvation.com/forums/magic-fundamentals/magic-general/768235-what-are-current-pack-odds-including-foils
     size = size - 1
     foilCard = _.choose(1, pickFoil(set))
     pack.push(foilCard[0])

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,8 @@ function toPack(code) {`
`163`	`163`	`}`
`164`	`164`	`}`
`165`	`165`	`}`
`166`		`- if (_.rand(6) < 1 && !(foilCard) && !(masterpiece)) {`
	`166`	`+ if (_.rand(7) < 1 && !(foilCard) && !(masterpiece)) {`
	`167`	`+ // http://www.mtgsalvation.com/forums/magic-fundamentals/magic-general/768235-what-are-current-pack-odds-including-foils`
`167`	`168`	`size = size - 1`
`168`	`169`	`foilCard = _.choose(1, pickFoil(set))`
`169`	`170`	`pack.push(foilCard[0])`