-
Notifications
You must be signed in to change notification settings - Fork 2
Raise NotFoundError rather than panic on non-existent file #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Agreed it should be impossible for the Python user to see a rust panic. |
FYI I'm running tests against all of the TIFFs that GDAL uses in its test suite and these are the files that generate rust panics (unrelated to non-existent files)- https://github.com/maxrjones/virtual-tiff/blob/afa8440dc776e79aec93aaaab043ac1d323ad3bf/tests/test_gdal_examples.py#L210-L235. I could organize these into other async-tiff issues if helpful. |
Yes, would be great to have a list of issues on what needs to be fixed/added still. As a suggestion, could you start with some of the predictor related tests, so that we can properly test #86? |
A RustPanic occurs when passing a non-existent file to
TIFF.open()
. Would it be possible to instead raise aFileNotFoundError
because this type of traceback would be unfamiliar to many Python users?The text was updated successfully, but these errors were encountered: