Skip to content

Commit de4cd5a

Browse files
peterpeterparkerpeterpeterparker
authored
fix: Self-closing HTML tags (#544)
# Motivation Fix a linter error reported by latest Svelte v5 linter in #541: > Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />`(element_invalid_self_closing_tag) svelte/valid-compile # Changes - Replace self closing tags. e.g. `<div />` -> `<div></div>`
1 parent 0331f06 commit de4cd5a

19 files changed

+32
-32
lines changed

‎src/lib/components/Backdrop.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
on:keypress={($event) => handleKeyPress({ $event, callback: close })}
2727
class:disablePointerEvents
2828
data-tid="backdrop"
29-
/>
29+
></div>
3030

3131
<style lang="scss">
3232
@use "../styles/mixins/interaction";

‎src/lib/components/ProgressBar.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
aria-valuemax={max}
5555
aria-valuenow={totalValue}
5656
style={inlineStyle}
57-
/>
57+
></progress>
5858
<slot name="bottom" />
5959
</div>
6060

‎src/lib/components/ProgressSteps.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
<span class="text">{text}</span>
2525

26-
<div class:line={!last} />
26+
<div class:line={!last}></div>
2727

2828
{#if state === "completed"}
2929
<span class="state">{$i18n.progress.completed}</span>

‎src/lib/components/QRCode.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
style={`width: ${size.width > 0 ? `${size.width}px` : "100%"}; height: ${
114114
size.width > 0 ? `${size.width}px` : "100%"
115115
}`}
116-
/>
116+
></canvas>
117117
{/if}
118118

119119
{#if showLogo}

‎src/lib/components/QRCodeReader.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
const mirror = isDesktop();
8686
</script>
8787

88-
<article class="reader" {id} class:mirror />
88+
<article class="reader" {id} class:mirror></article>
8989

9090
<style lang="scss">
9191
.reader {

‎src/lib/components/Segment.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
>
8383
{#if nonNullish(indicator)}
8484
<div class="indicator">
85-
<div class="indicator-background" />
85+
<div class="indicator-background"></div>
8686
</div>
8787
{/if}
8888

‎src/lib/components/Toggle.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
aria-label={ariaLabel}
2525
{disabled}
2626
/>
27-
<label for={id} />
27+
<label for={id}></label>
2828
</div>
2929

3030
<style lang="scss">

‎src/tests/lib/components/ContentTest.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
</script>
44

55
<Content>
6-
<div data-tid="content-test-slot" />
7-
<div data-tid="content-test-title-slot" slot="title" />
8-
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end" />
6+
<div data-tid="content-test-slot"></div>
7+
<div data-tid="content-test-title-slot" slot="title"></div>
8+
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end"></div>
99
</Content>

‎src/tests/lib/components/IslandTest.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
</script>
44

55
<Island>
6-
<div data-tid="island-test-slot" />
6+
<div data-tid="island-test-slot"></div>
77
</Island>

‎src/tests/lib/components/MenuItemTest.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
</script>
44

55
<MenuItem href="https://test">
6-
<div data-tid="menuitem-test-icon" slot="icon" />
7-
<div data-tid="menuitem-test-default" />
8-
<div data-tid="menuitem-test-status-icon" slot="statusIcon" />
6+
<div data-tid="menuitem-test-icon" slot="icon"></div>
7+
<div data-tid="menuitem-test-default"></div>
8+
<div data-tid="menuitem-test-status-icon" slot="statusIcon"></div>
99
</MenuItem>

‎src/tests/lib/components/MenuTest.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
</script>
44

55
<Menu>
6-
<div data-tid="menu-test-slot" />
6+
<div data-tid="menu-test-slot"></div>
77
</Menu>

‎src/tests/lib/components/NavTest.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
</script>
44

55
<Nav>
6-
<div data-tid="nav-test-1" />
7-
<div data-tid="nav-test-2" />
6+
<div data-tid="nav-test-1"></div>
7+
<div data-tid="nav-test-2"></div>
88
</Nav>

‎src/tests/lib/components/PopoverTest.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
</script>
44

55
<Popover visible={true}>
6-
<div data-tid="Popover-slot" />
6+
<div data-tid="Popover-slot"></div>
77
</Popover>

‎src/tests/lib/components/SplitBlockTest.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
</script>
44

55
<SplitBlock>
6-
<div data-tid="content-test-start-slot" slot="start" />
7-
<div data-tid="content-test-end-slot" slot="end" />
6+
<div data-tid="content-test-start-slot" slot="start"></div>
7+
<div data-tid="content-test-end-slot" slot="end"></div>
88
</SplitBlock>

‎src/tests/lib/components/SplitContentTest.svelte

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
</script>
88

99
<SplitContent bind:this={originalComponent}>
10-
<div data-tid="content-test-start-slot" slot="start" />
11-
<div data-tid="content-test-end-slot" slot="end" />
12-
<div data-tid="content-test-title-slot" slot="title" />
13-
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end" />
10+
<div data-tid="content-test-start-slot" slot="start"></div>
11+
<div data-tid="content-test-end-slot" slot="end"></div>
12+
<div data-tid="content-test-title-slot" slot="title"></div>
13+
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end"></div>
1414
</SplitContent>

‎src/tests/lib/components/SplitPaneTest.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
</script>
44

55
<SplitPane>
6-
<div data-tid="split-pane-test-slot" />
7-
<div data-tid="split-pane-test-menu-slot" slot="menu" />
6+
<div data-tid="split-pane-test-slot"></div>
7+
<div data-tid="split-pane-test-menu-slot" slot="menu"></div>
88
</SplitPane>

‎src/tests/lib/components/StretchPaneTest.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
</script>
44

55
<StretchPane>
6-
<div data-tid="stretch-pane-test-slot" />
7-
<div data-tid="stretch-pane-test-menu-slot" slot="menu" />
6+
<div data-tid="stretch-pane-test-slot"></div>
7+
<div data-tid="stretch-pane-test-menu-slot" slot="menu"></div>
88
</StretchPane>

‎src/tests/lib/components/TestIdWrapperTest.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
</script>
77

88
<TestIdWrapper {testId}>
9-
<div data-tid={childTestId} />
9+
<div data-tid={childTestId}></div>
1010
</TestIdWrapper>

‎src/tests/lib/components/ToolbarTest.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
</script>
44

55
<Toolbar>
6-
<div data-tid="toolbar-test-start-slot" />
7-
<div data-tid="toolbar-test-slot" />
8-
<div data-tid="toolbar-test-end-slot" />
6+
<div data-tid="toolbar-test-start-slot"></div>
7+
<div data-tid="toolbar-test-slot"></div>
8+
<div data-tid="toolbar-test-end-slot"></div>
99
</Toolbar>

0 commit comments

Comments
 (0)