Merge pull request phpbrew#1210 from flavioheleno/fix/php8-zts

Update ZTS variant for PHP8 build

Author: jhdxr

src/PhpBrew/VariantBuilder.php

@@ -153,7 +153,13 @@ public function __construct()
         $this->variants['ftp'] = '--enable-ftp';
         $this->variants['filter'] = '--enable-filter';
         $this->variants['gcov'] = '--enable-gcov';
-        $this->variants['zts'] = '--enable-maintainer-zts';
+        $this->variants['zts'] = function (ConfigureParameters $params, Build $build) {
+            if ($build->compareVersion('8.0') < 0) {
+                return $params->withOption('--enable-maintainer-zts');
+            }
+
+            return $params->withOption('--enable-zts');
+        };
 
         $this->variants['json'] = '--enable-json';
         $this->variants['hash'] = '--enable-hash';

tests/PhpBrew/VariantBuilderTest.php

@@ -294,4 +294,36 @@ public static function zipProvider()
             array('7.4.0-dev', '--with-zip'),
         );
     }
+
+    /**
+     * @param string $version
+     * @param string $expected
+     *
+     * @dataProvider ztsProvider
+     */
+    public function testZts($version, $expected)
+    {
+        $build = new Build($version);
+        $build->enableVariant('zts');
+
+        $builder = new VariantBuilder();
+        $options = $builder->build($build)->getOptions();
+
+        $this->assertArrayHasKey($expected, $options);
+    }
+
+    public static function ztsProvider()
+    {
+        return array(
+            array('5.3.0', '--enable-maintainer-zts'),
+            array('5.4.0', '--enable-maintainer-zts'),
+            array('5.5.0', '--enable-maintainer-zts'),
+            array('5.6.0', '--enable-maintainer-zts'),
+            array('7.0.0', '--enable-maintainer-zts'),
+            array('7.1.0', '--enable-maintainer-zts'),
+            array('7.3.0', '--enable-maintainer-zts'),
+            array('7.4.0', '--enable-maintainer-zts'),
+            array('8.0.0', '--enable-zts'),
+        );
+    }
 }